Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy matrix folder from test scenario #531

Draft
wants to merge 1 commit into
base: olusanya
Choose a base branch
from

Conversation

hsl-petrhaj
Copy link
Contributor

It's one small step for mock run, one giant leap for testing? Or not so much, but at least should enable having multiple testing scenarios under different names without having to move things in the folders manually.

Copy link
Collaborator

@zptro zptro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So to make it clear, this will save you from hassle when using test data as you will not have to change the Results folder in the project settings to make model runs with test data work? But what if you want to use MockAssignment with the full helmet data, but you do not have the matrices in the right directory? The model run will then happily continue, but you will then run into a problem of too small impedance matrices at a later stage.

raise NameError(msg)
log.info("Matrices folder does not exist, copying the folder from test scenario")
test_path = os.path.join(args.results_path,"test","Matrices")
import shutil
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imports should be at the top of the module.

@hsl-petrhaj
Copy link
Contributor Author

So to make it clear, this will save you from hassle when using test data as you will not have to change the Results folder in the project settings to make model runs with test data work? But what if you want to use MockAssignment with the full helmet data, but you do not have the matrices in the right directory? The model run will then happily continue, but you will then run into a problem of too small impedance matrices at a later stage.

Yes, that was the idea, but indeed this does not work well with mock run of real Helmet data. I have to rethink this a bit.

@zptro zptro marked this pull request as draft August 3, 2023 09:50
@johpiip johpiip removed their request for review August 17, 2023 07:29
@johpiip
Copy link
Contributor

johpiip commented Aug 17, 2023

I removed myself from reviewers as this is still in draft phase. Please tag me if you have any questions or we need to discuss something, or mark me as reviewer when this is ready for review. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should mock run create its own folder with matrices if we run a different scenario from "test"?
3 participants