Feat/noise prediction #532
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zptro
reviewed
Aug 9, 2023
Comment on lines
434
to
436
| if speed >= 40: | ||
| LAE_light = 73.5 + 25*log10(speed/50) | ||
| LAE_heavy = 80.5 |
There was a problem hiding this comment.
❗ This is not an elif clause, so it will always override the previous if.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should not be merged into this version of Helmet.
Updated noise calculation method based on the last update on the Nordic noise prediction method, as described in
https://books.googleusercontent.com/books/content?req=AKW5Qaen8XuI4Zzpi1yL840L0unyqTZfBK2-PBLlgS6UJwZpF7uCljYSA8sFP9-pFDwwYLEpPUmY5IOI59S8diml4cVcNUP_z-yANVY9sTdWdB09ITLJZxl518twmqELqP2a8VWIK8u-hHKK_bbpB8axGQFOZ65OUXXDroPlgrcvWr62f9gj6MIa9x8tNC5ceOpQQrXJnb-0ER0JOR9BLKIQxD300-Rtjk9Z6fzJF0-ACc38cQU-SR9EQYsZlMsD9HsiZt5N6Vqmju3kG5auHksVI8z3DhygIg
pp. 98 - 99
Compared to the currently used method, the areas affected by noise are greatly reduced. The last update included reflections from vertical surfaces, which may make up for the difference when doing actual noise assessments. However, since our model is only a noise emission model with atmospheric attenuation, reflections are not taken into account.