Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create emme_verkko.md #145

Merged
merged 35 commits into from Sep 12, 2022
Merged

Create emme_verkko.md #145

merged 35 commits into from Sep 12, 2022

Conversation

zptro
Copy link
Collaborator

@zptro zptro commented Jun 30, 2022

Added EMME network coding instructions.

Also decreased line length for some old files.

@zptro zptro requested review from johpiip and MerviV August 2, 2022 06:54
@zptro zptro marked this pull request as ready for review August 5, 2022 05:32
@zptro
Copy link
Collaborator Author

zptro commented Aug 29, 2022

Oh, how wonderful it would be to get this released, @johpiip ;)

@johpiip
Copy link
Contributor

johpiip commented Aug 29, 2022

@zptro I was planning on asking Mervi to review this after she comes back from her vacation, but if you consider it a masterpiece, I can merge it right away. 😄

@zptro
Copy link
Collaborator Author

zptro commented Aug 29, 2022

@johpiip, she actually already reviewed it (I am not 100 % sure it was a complete review though), but she did not do it in Github, she did it as a Teams message to me.

Copy link
Contributor

@johpiip johpiip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice update! I made a few review comments. If you want to, we can discuss them on phone so that I can update them per your instructions, or if you can spare a few minutes, maybe you could clarify them yourself?

docs/emme_verkko.md Outdated Show resolved Hide resolved
docs/emme_verkko.md Outdated Show resolved Hide resolved
docs/emme_verkko.md Show resolved Hide resolved
docs/emme_verkko.md Outdated Show resolved Hide resolved
docs/emme_verkko.md Show resolved Hide resolved
docs/emme_verkko.md Outdated Show resolved Hide resolved
docs/emme_verkko.md Show resolved Hide resolved
docs/emme_verkko.md Show resolved Hide resolved
docs/emme_verkko.md Outdated Show resolved Hide resolved
@johpiip
Copy link
Contributor

johpiip commented Aug 29, 2022

@johpiip, she actually already reviewed it (I am not 100 % sure it was a complete review though), but she did not do it in Github, she did it as a Teams message to me.

Oh okay, I did not know that!

@zptro
Copy link
Collaborator Author

zptro commented Sep 2, 2022

Very nice update! I made a few review comments. If you want to, we can discuss them on phone so that I can update them per your instructions, or if you can spare a few minutes, maybe you could clarify them yourself?

Good comments! However, I do not have the authority to do any changes to this branch. The only way for me right now to do the changes, would be to fork the repo and start a new PR.

@zptro
Copy link
Collaborator Author

zptro commented Sep 2, 2022

Fixed according to the comments and changed accidental tabs into space.

@zptro zptro requested a review from johpiip September 2, 2022 11:39
Copy link
Contributor

@johpiip johpiip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! I added @eevavesaoja as a reviewer. @zptro, you can either merge this right away, or wait for another round of comments. Thank you for your hard work!

@zptro zptro merged commit 52efcee into master Sep 12, 2022
@zptro zptro deleted the emme_coding branch September 12, 2022 10:30
@zptro
Copy link
Collaborator Author

zptro commented Sep 12, 2022

We can do revisions as separate PR if needed.

Copy link
Contributor

@eevavesaoja eevavesaoja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moi! Tässä pari kommenttia/kysymystä sivusta emme_verkko.md (hienoa että tämäkin on koottu githubiin!):

"Sijoitteluskripti muuttaa linkien funktio-, nopeus- ja kapasiteettiattribuutit (vdf, ul1, ul2) type-attribuutin perusteella. Kaikille katu- ja tieverkon linkeille ei ole saatu tuotettua taulukko 11:n mukaista linkkityyppiä. "
Tarkoitetaanko tällä ohjetta, että ”Koodaa yleisesti ottaen pelkkä type”?

Voisi selostaa mitä us2-skripti tekee pääpiirteissään? (jos ei ymmärrä python-skriptiä)

@johpiip
Copy link
Contributor

johpiip commented Jan 3, 2023

Nämä kaksi on lisätty uusiksi issueiksi!

Moi! Tässä pari kommenttia/kysymystä sivusta emme_verkko.md (hienoa että tämäkin on koottu githubiin!):

"Sijoitteluskripti muuttaa linkien funktio-, nopeus- ja kapasiteettiattribuutit (vdf, ul1, ul2) type-attribuutin perusteella. Kaikille katu- ja tieverkon linkeille ei ole saatu tuotettua taulukko 11:n mukaista linkkityyppiä. " Tarkoitetaanko tällä ohjetta, että ”Koodaa yleisesti ottaen pelkkä type”?

Voisi selostaa mitä us2-skripti tekee pääpiirteissään? (jos ei ymmärrä python-skriptiä)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants