New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create emme_verkko.md #145
Conversation
Oh, how wonderful it would be to get this released, @johpiip ;) |
@zptro I was planning on asking Mervi to review this after she comes back from her vacation, but if you consider it a masterpiece, I can merge it right away. 😄 |
@johpiip, she actually already reviewed it (I am not 100 % sure it was a complete review though), but she did not do it in Github, she did it as a Teams message to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice update! I made a few review comments. If you want to, we can discuss them on phone so that I can update them per your instructions, or if you can spare a few minutes, maybe you could clarify them yourself?
Oh okay, I did not know that! |
Good comments! However, I do not have the authority to do any changes to this branch. The only way for me right now to do the changes, would be to fork the repo and start a new PR. |
Fixed according to the comments and changed accidental tabs into space. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! I added @eevavesaoja as a reviewer. @zptro, you can either merge this right away, or wait for another round of comments. Thank you for your hard work!
We can do revisions as separate PR if needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moi! Tässä pari kommenttia/kysymystä sivusta emme_verkko.md (hienoa että tämäkin on koottu githubiin!):
"Sijoitteluskripti muuttaa linkien funktio-, nopeus- ja kapasiteettiattribuutit (vdf, ul1, ul2) type-attribuutin perusteella. Kaikille katu- ja tieverkon linkeille ei ole saatu tuotettua taulukko 11:n mukaista linkkityyppiä. "
Tarkoitetaanko tällä ohjetta, että ”Koodaa yleisesti ottaen pelkkä type”?
Voisi selostaa mitä us2-skripti tekee pääpiirteissään? (jos ei ymmärrä python-skriptiä)
Nämä kaksi on lisätty uusiksi issueiksi!
|
Added EMME network coding instructions.
Also decreased line length for some old files.