feat: 課程列表 page 功能 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paperhsiaooo
requested changes
May 21, 2023
Comment on lines
9
to
13
| const page = req.query.page || 1 | ||
| const limit = 20 | ||
| const offset = (page - 1) * limit | ||
|
|
||
| const courseData = await Course.findAndCountAll({ |
There was a problem hiding this comment.
Limit 會是由前端送給後端
這樣當前端要改成單頁 10 筆時，後端也不用跟著動了
這部分可能再修正一下
| }) | ||
|
|
||
| const courses = courseData.map((course) => { | ||
| console.log(courseData.rows) |
ankazu
commented
May 22, 2023
Comment on lines
9
to
13
| const page = req.query.page || 1 | ||
| const limit = 20 | ||
| const offset = (page - 1) * limit | ||
|
|
||
| const courseData = await Course.findAndCountAll({ |
| }) | ||
|
|
||
| const courses = courseData.map((course) => { | ||
| console.log(courseData.rows) |
paperhsiaooo
approved these changes
May 22, 2023
|
@ankazu 感謝 John，再麻煩合併至 dev branch 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
page 設定，上限 20 筆資料