購物車金流相關調整 #23
Merged
購物車金流相關調整 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paperhsiaooo
requested changes
Jun 8, 2023
Comment on lines
42
to
54
| const calculateTotalPrice = (courseData) => { | ||
| let totalPrice = 0 | ||
|
|
||
| courseData.forEach((course) => { | ||
| if (course.price < course.originPrice) { | ||
| totalPrice += course.price | ||
| } else { | ||
| totalPrice += course.originPrice | ||
| } | ||
| }) | ||
|
|
||
| return totalPrice | ||
| } |
There was a problem hiding this comment.
Controller 內部通常都放跟路由後續有關動作的 js
- calculateTotalPrice 的 function 應放在 src 下的 js 或 utils 內，可能需找個適當的 js 放入
controllers/cartController/crypt.js
Outdated
There was a problem hiding this comment.
先前沒注意到 crypt.js 也應放在 src 下的 js 或者 utils 的資料夾下
controllers/cartController/index.js
Outdated
| @@ -8,71 +8,40 @@ const { | |||
| create_mpg_sha_encrypt, | |||
| create_mpg_aes_decrypt | |||
| } = require('./crypt') | |||
| const { getCourseData, calculateTotalPrice } = require('./cartOperations') | |||
There was a problem hiding this comment.
路徑需跟著 cartOperations 位置改變而更動
|
@ankazu 再麻煩修正了 |
paperhsiaooo
approved these changes
Jun 9, 2023
|
@ankazu ok，再麻煩合併了🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cart 取得課程相關資料與總價計算，重複使用函式，另開新檔。
金流混淆參數增加 Name
order 新增 name 參數、商品詳細上限50字元。
createOrder 修改訂單參數、取得課程總價