Added filtering to request list on itinerary details.

[dchristensen]

Fixes #1100

[tonysurma]

@stevejgordon can you give this a quick review, @dchristensen thanks

[stevejgordon]

@dchristensen Firstly, thanks for this PR. It looks close but I ran into some issues when loading the site due to the form. (Please see comment).

Fixing up the form should make it function correctly. One further point though is that if the filter returns no requests the message we'll see is "There are currently no assigned requests for this itinerary". We might need to do something to ensure that this is more clear. Something like "No requests to show with current filtering". Of course if we actually have no records in the first place we should always show the original message. Does that make sense?

Thanks for including and expanding on the tests.

[stevejgordon]

There seem to be a couple of problems with this form. Firstly it's not sending an anti forgery token so we get blocked by MVC (bad request) on the POST. The best option to fix this is to use the form taghelpers which will actually render an anti-forgery token for us automatically.

<form asp-action="Details" asp-controller="Itinerary" asp-area="Admin">
    // You inputs etc here
</form>

Secondly, I'm not clear why the #requests string is in there currently?

[dchristensen]

@stevejgordon The #request is being appended to the URL (and the tag helpers are not being used) so that the posted URL ends up as /Admin/Itinerary/Details/5#requests, for example. I'm adding the target hash because when the filter button is clicked and the page reloads you are left back at the top of the page. This felt like a bad experience for the user, especially if there are several team members assigned to the itinerary pushing the requests further down the page. This addition makes sure the the requests are shown at the top of the screen when the page loads.

I can just add in the older style @Html.AntiForgeryToken() inside the form unless you have a suggestion for an alternative solution.

[stevejgordon]

@dchristensen - That's a fair reason! I'm not sure if it can be done within the form tag-helper. @dpaquette might have some better knowledge on that. But adding in the AntiForgery token might be the pragmatic approach.

[dpaquette]

I have not tried adding a hash to a form action using the tag helper approach. If it doesn't work then adding @Html.AntiForgeryToken() should be sufficient here.

[tonysurma]

@stevejgordon can you take a re-review? looks like @dchristensen updated post your comments. Thanks

[stevejgordon]

Thanks very much @dchristensen. This worked fine with the anti-forgery added so we're good to

Thanks for the contribution and the rapid review changes.