#1707 social login error #1735
Merged
#1707 social login error #1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ompleting additional information form no longer leaves the login process in an invalid state
|
Thanks @stevejgordon for finding this bug and thanks @shahiddev for fixing this PR. I'll get eyes on this soon. |
|
@shahiddev SOLID PR! Thanks so much for taking the time to investigate and fix this. @tonysurma |
mgmccarthy
approved these changes
Jan 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1707 - Navigating away from additional information page after using social login no longer leaves the login process in invalid state requiring cookie clean up. Solution is identical to that made to the default account controller template in github (aspnet/Identity#915 (comment))
Additional fixes added to handle remote failure of social logins where user is not authenticated (e.g. cancelled consent), user is now redirected back to login screen instead of crashing.