Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct template and fix no-pagination #486

Merged
merged 1 commit into from
Jul 31, 2020

Conversation

priyanshunayan
Copy link
Member

Fixes #485

Checklist

  • My branch is up-to-date with upstream/develop branch.
  • Everything works and tested for Python 3.5.2 and above.

Description

  • This PR removes the error thrown on making GET request on Collection endpoints when started via cli with --no-pagination flag.
  • As we have discussed earlier, the wrong template was returned. So one minor change this PR does is that replaces parentheses by curly braces and add ? symbol to indicate key-value pairs are accepted. Ref: https://tools.ietf.org/id/draft-gregorio-uritemplate-08.html#rfc.section.3.2.8

Change logs

  • Curly braces instead of paranthesis
  • Maximum possible number of members in non-paginated collection

@chrizandr chrizandr merged commit 0fadcb4 into HTTP-APIs:develop Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants