Update sample docs #491
Merged
Update sample docs #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check why builds are failing |
|
@chrizandr New tests have been added in #490 Once these two PRs are merged, they will work fine. @sameshl has tested everything with the updated docs from my fork locally and everything works fine. |
|
Yes, the build is failing for the same reason I pointed out here. |
chrizandr
approved these changes
Aug 11, 2020
|
Builds still failing after 490 merger |
priyanshunayan
force-pushed
the
new_doc
branch
from
53a6d8b
to
741fe91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #482
Checklist
Description
According to the latest changes in the core library, this PR updates the sample docs used throughout and also the sample code used to generate the sample docs.
Change logs