-
-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Images with long description should have the long description accessible to everyone #854
Comments
Thanks for raising this @juliemoynat ! We hadn't considered the long descriptions to be useful for non-screen reader users, but now you've raised this I agree they would be - and there is no reason not to make them available to all. Since you've knocked up the code pen already, would you be willing to submit a PR for this? Questions over your current code pen:
But in principal I like the idea.
I'm going to raise this as a separate issue - #856 |
Hi @bazzadp, I would like to submit a PR but I'm not good at JavaScript development. The JavaScript code in my CodePen is not from me. You're right with your first question about the My CodePen is just an example so I didn't take time to code a piece of CSS. |
Well if you want to submit a PR, then we'd be more than willing to help guide you through that and review and suggest improvements to any of the code you submit. Alternatively, if you'd prefer not to, that's fine too - raising issues so others can correct is also very helpful! Let us know either way, so others can look at it if you don't want to do this. |
Thank you so much for your understanding. I am not ready to submit this kind of PR so I prefer to let others correct it. I could help for tests if you need to. |
Knocked up something here: https://20200521t143054-dot-webalmanac.uk.r.appspot.com/fr/2019/accessibility#fig-1 Let me know your thoughts. Also let me know if Google's suggested French wording for Show Description/Hide Description is the best wording for here!
That is interesting. Do these bugs also apply if the |
I will answer you in several points below because there are multiple complicated subjects here.
So in our example, the image with it's <img alt="Figure 1. Example of what text with insufficient color contrast looks like. Long description available below" src="/static/images/2019/accessibility/example-of-good-and-bad-color-contrast-lookzook.png" loading="lazy" width="600" height="278"> And the caption wouldn't change: <figcaption id="fig1-caption">
<a href="#fig-1" class="anchor-link">Figure 1.</a> Example of what text with insufficient color contrast looks like. Courtesy of LookZook
</figcaption> |
Thank you so much for your valuable input here! On The duplication of the
Additionally this reference states the `aria-labelledby' will be used in preference:
So presumably no harm to have both? To be honest, if it's not causing any harm, I'm tempted to leave this as it's a lot of HTML to change. Should be able to automate removing it with some regexs but, again, if no harm then still tempted to leave as technically they are both correct. On The Additionally that previous reference states this should be usable:
To be honest, I'd prefer to leave this as is for those screen readers that do support this, and in the hope that those that don't aren't suffering too much given that we repeat the image description below now, and the image label in the I have taken your suggestion to add the figure number to the button, and also made the buttons bigger on mobile. Checkout latest version here: https://20200521t203320-dot-webalmanac.uk.r.appspot.com/fr/2019/accessibility#fig-1 |
By the way, thank you so much for having added the "Show / hide description" button! 👍 |
Oh that's interesting. I presumed As per the PowerMapping test:
That's why I liked creating links via Now if some screen readers ignore this attribute completely I'm fine (same as removing as you suggest), and if a few screen readers read this out by default, then that's not ideal (though a bug in screen readers IMHO). However if a lot of screen readers read this out by default, then I agree that is far from ideal (though still a bug in screen readers IMHO) and we maybe should consider removing it as you say. As I say, my gut feel is still to leave as is, for the screen readers that support this attribute properly. Users can always skip past the text if they get bored of hearing it, and they are somewhat used to repetition is my understanding. Anyway, I think the show hide button is a good addition, and opened #857 for that so hopefully will get that out in next few days, at which point I'll close this issue. But do feel free to continue this discussion here if you can spare the time and have anything else to add - I find it very interesting. Like most things in life, it seems there are no absolute right and wrongs and a lot of this is judgement calls. |
When it works, NVDA and VoiceOver are reading the A colleague told me that this is the way screen readers should work with this attribute according to official specifications but I didn't succeed in finding a resource about it at the moment. I've made some others tests this morning and found that, with NVDA, an Screen readers obviously need to improve their handling on this topic. |
Yup! And, like with other browser funnies, the question is how much do you work around known issues? A careful judgement call between how badly it's broken for those that don't support it properly, how many people likely to be affected, how much there is to gain by doing it "the right way", how much effort there is involved in working around them, and how much we're allowing the status quo to continue by working around the issue for them! |
Hello,
In the website, there are some pages with images that requires long description.
Long description are hidden by default and can be read only by people using a screen reader.
Long description are useful for people who can't see images like blind people and for people who can't see images well like visually impaired people who need to zoom inside the page. They can also be useful for people with some cognitive or mental disabilities.
So, long descriptions should not be hidden but should be accessible to everyone.
As an example, I learned in the long description of the image about contrasts that the grey boxes are the orange boxes in greyscale. How all people can be aware of it without being able to read the long description?
To fix it, you can hide the long description behind an accessible "Show / hide" button so that it will not take up a lot of place.
I made a CodePen to have an example: https://codepen.io/juliemoynat/pen/ZEbwbvp
In addition, the
aria-describedby
attribute on<img>
tag is unfortunately not compatible with screen readers at the moment: https://www.powermapper.com/tests/screen-readers/labelling/img-aria-describedby/The text was updated successfully, but these errors were encountered: