Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature flag metric #104

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Conversation

devknoll
Copy link
Contributor

@devknoll devknoll commented Jan 8, 2024

The detail field in performance.mark doesn't seem to be available in HTTP Archive, so this PR adds a custom metric that extracts a set of feature names according to the User Timing specification. This also includes support for the previous name, since some pages are using it.

Test websites:

@rviscomi
Copy link
Member

rviscomi commented Jan 9, 2024

FYI if you include this markdown in your PR description, the GH action will automatically test your changes on the provided URLs:

**Test websites**:

- https://example.com/

(I've updated the PR template so it should be clearer next time)

@devknoll
Copy link
Contributor Author

devknoll commented Jan 9, 2024

Neat 👍 I edited and kicked it off so I could see :)

Copy link

github-actions bot commented Jan 9, 2024

Custom metrics for https://almanac.httparchive.org/en/2022/

WPT test run results: http://webpagetest.httparchive.org/results.php?test=240109_KZ_2

Custom metrics for https://angular.io/

WPT test run results: http://webpagetest.httparchive.org/results.php?test=240109_1V_3
Changed custom metrics values:

{
    "_aurora": {
        "ng_version": "17.0.0",
        "ng_img_user": null,
        "ng_priority_img_count": null,
        "nuxt_version": null,
        "nuxt_vue_version": null,
        "react_version": null,
        "svelte_version": null,
        "feature_flags": [
            "NgControlFlow"
        ]
    }
}
Custom metrics for https://angular.dev/

WPT test run results: http://webpagetest.httparchive.org/results.php?test=240109_08_4
Changed custom metrics values:

{
    "_aurora": {
        "ng_version": "17.0.0-rc.1",
        "ng_img_user": null,
        "ng_priority_img_count": null,
        "nuxt_version": null,
        "nuxt_vue_version": null,
        "react_version": null,
        "svelte_version": null,
        "feature_flags": [
            "NgHydration",
            "NgDefer",
            "NgAfterNextRender",
            "NgHttpTransferCache"
        ]
    }
}
Custom metrics for https://svelte.dev/

WPT test run results: http://webpagetest.httparchive.org/results.php?test=240109_CD_5
Changed custom metrics values:

{
    "_aurora": {
        "ng_version": null,
        "ng_img_user": null,
        "ng_priority_img_count": null,
        "nuxt_version": null,
        "nuxt_vue_version": null,
        "react_version": null,
        "svelte_version": "4",
        "feature_flags": []
    }
}

@rviscomi
Copy link
Member

rviscomi commented Jan 9, 2024

@pmeenan since WPT has support for custom marks and measures, is this something that could be useful upstream?

Copy link
Member

@rviscomi rviscomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. The WPT question shouldn't be blocking.

@rviscomi rviscomi merged commit e037e9d into HTTPArchive:main Jan 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants