Fix home page filtering for summary requests #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add `metadata` attribute to `status_info` to make it available for filtering downstream * update unit tests
Coverage reportThe coverage rate went from
Diff Coverage details (click to unfold)modules/utils.py
Missing lines: |
SELECT
COUNT(DISTINCT pageid)
FROM
`httparchive.experimental_gc_summary_requests_home_only.2022_09_01_mobile`Result is 15077843 which indicates that the results only include home pages, as expected 👍 |
rviscomi
approved these changes
Dec 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #153
Changes
add
metadataattribute tostatus_infoto make it available for filtering downstreamupdate unit tests
Validation
https://console.cloud.google.com/dataflow/jobs/us-west1/2022-12-09_11_45_45-6722142626272382025?project=httparchive