Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added example for multivariate qc in json #48

Merged
merged 1 commit into from
Feb 21, 2019

Conversation

mwalzer
Copy link
Collaborator

@mwalzer mwalzer commented Oct 25, 2018

No description provided.

@bittremieux
Copy link
Collaborator

bittremieux commented Oct 25, 2018

It took me a little while to realize, but by repeating RawFile elements for each of the three input files (line 8–31–54) you also get invalid JSON because there are duplicate RawFile property keys.

A similar problem would occur if you have multiple general InputFiles. I might just remove that property key in the JSON schema and have a list of inputFiles instead. That makes the schema easier at least. Although having a raw file is then less explicit.

bittremieux added a commit that referenced this pull request Oct 25, 2018
Otherwise we can't have multiple input files as they will have a
duplicate property key. See #48.
bittremieux added a commit that referenced this pull request Oct 25, 2018
@bittremieux
Copy link
Collaborator

I adapted the example to validate against the JSON schema because I wanted to make sure the schema supported multi-file information, see 4b1b13a.

I've split the three files over three different runQualitys, followed by a setQuality for the combined statistic.

When we do it like this in a single file, the question is what we need to specify as inputFiles for the setQuality? I've duplicated the inputFiles from the three preceding runQualitys now, but that's not entirely correct because the input is actually the information in the runQuality derived from those input files.
If the runQualitys would have been stored in individual mzQC files then we could refer to those files instead, but that's not possible in this case.
So how should we do that here?

Side note: probably the inputFiles for the runQualities should include some identification files as well because some of the QC metrics are ID-based.

@mwalzer mwalzer merged commit 8daad64 into HUPO-PSI:master Feb 21, 2019
@mwalzer mwalzer deleted the OpenMS-qcml-json branch February 21, 2019 09:48
@mwalzer
Copy link
Collaborator Author

mwalzer commented Feb 21, 2019

We should move schema to v0_1_0 from @bittremieux s v0_0_11 after adding more examples. (Also to stay in sync with CV.)

mwalzer pushed a commit to mwalzer/qcML-development that referenced this pull request Jul 18, 2019
Otherwise we can't have multiple input files as they will have a
duplicate property key. See HUPO-PSI#48.
mwalzer pushed a commit to mwalzer/qcML-development that referenced this pull request Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants