Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor property changes in the schema #42

Merged
merged 7 commits into from
Oct 30, 2019
Merged

Minor property changes in the schema #42

merged 7 commits into from
Oct 30, 2019

Conversation

ypriverol
Copy link
Contributor

No description provided.

This was referenced Aug 21, 2019
Closed
Closed
edeutsch
edeutsch approved these changes Aug 21, 2019
View reviewed changes
Copy link
Contributor

@edeutsch edeutsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this, but Jeremy should weigh in too before the merge.

@ypriverol ypriverol mentioned this pull request Aug 21, 2019
Closed
edeutsch
edeutsch approved these changes Aug 21, 2019
View reviewed changes
Copy link
Contributor

@edeutsch edeutsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me. I approve. Maybe one more approval from @jjcarver before we merge?

@edeutsch
Copy link
Contributor

edeutsch commented Sep 4, 2019

Hi @jjcarver, do you approve of these changes to better align PX XML and JSON?

jjcarver
jjcarver approved these changes Sep 6, 2019
View reviewed changes
Copy link
Collaborator

@jjcarver jjcarver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. This all looks good to me. I definitely agree we should keep things as consistent as possible between PROXI and PX XML when referring to the exact same concepts.

@ypriverol ypriverol merged commit 9ba9892 into HUPO-PSI:master Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edeutsch edeutsch edeutsch approved these changes

@jjcarver jjcarver jjcarver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ypriverol @edeutsch @jjcarver