Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding peptide and spectrum identification count terms #117

Merged
merged 3 commits into from
Mar 25, 2022

Conversation

mwalzer
Copy link
Contributor

@mwalzer mwalzer commented Mar 24, 2022

resolves #116

Copy link
Contributor

@mobiusklein mobiusklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@edeutsch edeutsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good, I have a few nitpicky things:

  1. Although the first time name is "count of identified peptides", the definition is "peptidoforms". This is thus ambiguous. Elsewhere in the CV we try to draw the distinction between "distinct peptide sequences" and "distinct peptidoforms" (which include mass mods). I suggest making the term name and definition match.

  2. In both terms, it seems a little odd that the names are "...identified..." but the definitions are "...identified and pass threshold..." Maybe if would clearer if the definitions were:

"The number of xxxxxxxxxxx that pass the threshold to be considered identified with sufficient confidence."

Copy link
Contributor

@edeutsch edeutsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks!

@mobiusklein mobiusklein merged commit c23e165 into master Mar 25, 2022
@bittremieux bittremieux deleted the mwalzer-fix-116 branch March 25, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

identification counts
4 participants