Fix retain cycle causing leak for backgroundPolicy RKRequestBackgroun…

…dPolicyContinue. closes RestKit#548
HYPERHYPER · Mar 12, 2012 · 749c6e3 · 749c6e3
1 parent 995c309
commit 749c6e3
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/Code/Network/RKRequest.m b/Code/Network/RKRequest.m
@@ -502,14 +502,16 @@ - (void)sendAsynchronously {
             RKLogInfo(@"Beginning background task to perform processing...");
 
             // Fork a background task for continueing a long-running request
+            __block RKRequest* weakSelf = self;
+            __block id<RKRequestDelegate> weakDelegate = _delegate;
             _backgroundTaskIdentifier = [app beginBackgroundTaskWithExpirationHandler:^{
                 RKLogInfo(@"Background request time expired, canceling request.");
 
-                [self cancelAndInformDelegate:NO];
-                [self cleanupBackgroundTask];
+                [weakSelf cancelAndInformDelegate:NO];
+                [weakSelf cleanupBackgroundTask];
 
-                if ([_delegate respondsToSelector:@selector(requestDidTimeout:)]) {
-                    [_delegate requestDidTimeout:self];
+                if ([weakDelegate respondsToSelector:@selector(requestDidTimeout:)]) {
+                    [weakDelegate requestDidTimeout:weakSelf];
                 }
             }];