Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unintended writes #37

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Commits on Mar 11, 2015

  1. Add .travis.yml

    f1ori committed Mar 11, 2015
    Configuration menu
    Copy the full SHA
    12bef59 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2015

  1. Configuration menu
    Copy the full SHA
    90ca6d0 View commit details
    Browse the repository at this point in the history
  2. Do not fetch attribute types on can_bind

    As the connection is only established to test authentication, attribute
    types are never used and we don't need to retrieve them
    f1ori committed Mar 17, 2015
    Configuration menu
    Copy the full SHA
    379c168 View commit details
    Browse the repository at this point in the history
  3. Return None for empty single-value attributes

    This corresponds better what happens for multi-value attributes, where
    an empty set is returned
    f1ori committed Mar 17, 2015
    Configuration menu
    Copy the full SHA
    8cdc507 View commit details
    Browse the repository at this point in the history
  4. Fix writes of unchanged empty attributes

    Some multi-value attributes were written although they where never
    changed. Accessing them created an empty set, which is different from
    the old value None. This unintented writing caused errors, when the user
    only has permission to read the attribute.
    
    The test-suite was updated to use a none-admin user for testing.
    f1ori committed Mar 17, 2015
    Configuration menu
    Copy the full SHA
    a10b0f3 View commit details
    Browse the repository at this point in the history