Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update app ready wait for Electron 13 #6

Merged
merged 1 commit into from Feb 24, 2022

Conversation

scowalt
Copy link
Contributor

@scowalt scowalt commented Oct 12, 2021

I was upgrading an Electron app from version 12.2.1 to 13.5.1. I noticed some issues with the next-electron-server not starting. After some investigation, I was able to fix the issue locally by using app.whenReady() instead of app.once("ready").

I'm not 100% sure why this fix works, or why Electron 13 broke it! From the description of app.whenReady() in the Electron docs, it seems like this is its intended use:

Returns Promise<void> - fulfilled when Electron is initialized. May be used as a convenient alternative to checking app.isReady() and subscribing to the ready event if the app is not ready yet.

Maybe in Electron 13 you can't register app.once if the app isn't ready yet?

@scowalt scowalt changed the title Update Electron app ready wait for Electron 13 Update app ready wait for Electron 13 Oct 12, 2021
@HaNdTriX
Copy link
Owner

Thanks!

@HaNdTriX HaNdTriX merged commit 41abb19 into HaNdTriX:master Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants