Update app ready wait for Electron 13 #6
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was upgrading an Electron app from version
12.2.1
to13.5.1
. I noticed some issues with thenext-electron-server
not starting. After some investigation, I was able to fix the issue locally by usingapp.whenReady()
instead ofapp.once("ready")
.I'm not 100% sure why this fix works, or why Electron 13 broke it! From the description of
app.whenReady()
in the Electron docs, it seems like this is its intended use:Maybe in Electron 13 you can't register
app.once
if the app isn't ready yet?