Fixed button blinking after clicking on it. #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Therzok
added a commit
that referenced
this pull request
Mar 17, 2013
Fixed button blinking after clicking on it.
|
I considered this safe to merge, so I merged it. :p |
|
Nice! I assume the bug was that both buttons were fighting each other for focus? |
|
No, it was never getting unfocused after click. Click one button, and it remains like that. |
|
Even if you clicked another button? Seems like a bug in WPF, no? |
|
Yeah, it looks like a bug in WPF, not a code bug. Searched info on it and found out it's a general button problem. When you click it, focused is set to true and haven't seen the blinking stop. Therefore, clicking Refresh would make it permanently blink. |
|
Interesting. Well, nice fix. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug where the Refresh and Browse for a Repository buttons would've continuously blinked after a click on it.