Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operator overloads #8

Merged
merged 1 commit into from Mar 15, 2012
Merged

Operator overloads #8

merged 1 commit into from Mar 15, 2012

Conversation

gpshonik
Copy link
Contributor

Hi - I added a minor fix to the nullity checks in CommitVertex.cs and CommitEdge.cs - I was crashing on some local git repos that had been cloned from svn.

Thanks!

… and object identity (was causing some issues for me)
@haacked
Copy link
Owner

haacked commented Mar 15, 2012

Thanks! Do you have a unit test that shows the problem?

haacked added a commit that referenced this pull request Mar 15, 2012
@haacked haacked merged commit cfebd2d into haacked:master Mar 15, 2012
@gpshonik
Copy link
Contributor Author

Yes. Sorry, about that. I should have included them. The following tests
failed prior to the fix.

CommitVertexTests.cs
[Fact]
public void ReturnsTrueIfCommitVertexIsNull()
{
CommitVertex commit = null;
Assert.True(commit == null);
}

CommitEdgeTests.cs
[Fact]
public void ReturnsTrueIfCommitEdgeIsNull()
{
CommitEdge edge = null;
Assert.True(edge == null);
}

On Thu, Mar 15, 2012 at 9:07 AM, Phil Haack <
reply@reply.github.com

wrote:

Thanks! Do you have a unit test that shows the problem?


Reply to this email directly or view it on GitHub:
#8 (comment)

@haacked
Copy link
Owner

haacked commented Mar 15, 2012

Thanks a lot! i've added them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants