New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Jekyll Blog Comments #316

Merged
merged 4 commits into from Jun 25, 2018

Conversation

Projects
None yet
1 participant
@Haacked
Owner

Haacked commented May 27, 2018

Following the instructions in https://github.com/damieng/jekyll-blog-comments
to set up haacked.com to use a jekyll+azure based comment system.

I still need to add all the comments and test this out.

TODID

  • Move JavaScript to its own file.
  • Add a remember me button.

It's hard to look at the changes because there are so many file changes, but this PR contains four commits:

  1. The changes to my Jekyll templates. This is the interesting commit!
  2. Import all of the comments.
  3. This blog post announcing the change.
  4. A commit where I update the post to link to the third commit. I can link to it here because updating the PR doesn't create a new commit. I couldn't link to it in the actual blog post because then I'd need to create a fifth commit and so on and so on.

@Haacked Haacked changed the title from WIP: Implement Jekyll Blog Comments to Implement Jekyll Blog Comments Jun 25, 2018

Haacked added some commits May 27, 2018

Implement Jekyll Blog Comments
Following the instructions in https://github.com/damieng/jekyll-blog-comments
to set up haacked.com to use a jekyll+azure based comment system.

@Haacked Haacked merged commit 8bce6ac into gh-pages Jun 25, 2018

@Haacked Haacked deleted the add-comment-system branch Jun 25, 2018

Haacked added a commit that referenced this pull request Nov 4, 2018

Merge pull request #316 from Haacked/add-comment-system
Implement Jekyll Blog Comments

Former-commit-id: 8bce6ac
Former-commit-id: b87b5ff

Haacked added a commit that referenced this pull request Nov 4, 2018

Merge pull request #316 from Haacked/add-comment-system
Implement Jekyll Blog Comments

Former-commit-id: 8bce6ac
Former-commit-id: b87b5ff

Haacked added a commit that referenced this pull request Nov 4, 2018

Merge pull request #316 from Haacked/add-comment-system
Implement Jekyll Blog Comments

Former-commit-id: 8bce6ac
Former-commit-id: b87b5ff
Former-commit-id: 8e1b28192658bf1a6bfa9602c8f1da9e069c0fa6 [formerly b4030cb43276b32bfaadc7e65df487fdcb30a4c4]
Former-commit-id: 1372e684ab75e0eed6b53a6c9b31d65ec1ba2911
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment