Fix FSDP ci test issue with "TypeError: Object of type Tensor is not … #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…JSON serializable" Transformer 4.38 logs the grad_norm in log_history. But FSDP doesn't have global grad norm function. When logging non-scalar tensor, the .item fails. The solution now is not to log grad_norm in logging_history for FSDP.
|
@libinta why do we need this on OH-fork? These changes should come to OH-fork when we rebase OH-fork to next OH release, we do not need to cherry-pick these. |
|
That’s why I ask you to review to see if it’s needed.
Got it.
From: Vivek Goel ***@***.***>
Sent: Thursday, March 28, 2024 10:05 PM
To: HabanaAI/optimum-habana-fork ***@***.***>
Cc: Libin Tang ***@***.***>; Mention ***@***.***>
Subject: Re: [HabanaAI/optimum-habana-fork] Fix FSDP ci test issue with "TypeError: Object of type Tensor is not … (PR #137)
@libinta<https://github.com/libinta> why do we need this on OH-fork? These changes should come to OH-fork when we rebase OH-fork to next OH release, we do not need to cherry-pick these.
—
Reply to this email directly, view it on GitHub<#137 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AGLGHZIO2HF5BW2F4XQUS5DY2TY7VAVCNFSM6AAAAABFNPAYROVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRWGY2TIOJWGY>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…JSON serializable"
Transformer 4.38 logs the grad_norm in log_history. But FSDP doesn't have global grad norm function. When logging non-scalar tensor, the .item fails. The solution now is not to log grad_norm in logging_history for FSDP.
What does this PR do?
Fixes # (issue)
Before submitting