Tap on checklist entry opens the TaskFormActivity

[negue]

1. open the checklist in the MainActivity
2. tap on the text of one
3. the TaskForm is opened

[phillipthelen]

that tapping on the text opens the taskform is intentional. Tapping on the checkbox works though, right?

[negue]

tapping on the checklist-item-text is intentional too?

Checkbox on/off works yup!

[phillipthelen]

Yes.
Ideally it would later also select the matching checklist item for editing when you tap on one, but that can be done later.

[negue]

Hm okay, but then it crashes^^ if you go back (back button)

[franzejr]

1. Open the app
2. Go to Dailies
3. Click on the text of a Daily
4. Crashes

                                                                                     Process: com.habitrpg.android.habitica.debug, PID: 28249
                                                                                     android.database.sqlite.SQLiteConstraintException: Days.user_id may not be NULL (code 19)
                                                                                         at android.database.sqlite.SQLiteConnection.nativeExecuteForLastInsertedRowId(Native Method)
                                                                                         at android.database.sqlite.SQLiteConnection.executeForLastInsertedRowId(SQLiteConnection.java:782)
                                                                                         at android.database.sqlite.SQLiteSession.executeForLastInsertedRowId(SQLiteSession.java:788)
                                                                                         at android.database.sqlite.SQLiteStatement.executeInsert(SQLiteStatement.java:86)
                                                                                         at com.raizlabs.android.dbflow.sql.SqlUtils.insert(SqlUtils.java:314)
                                                                                         at com.raizlabs.android.dbflow.sql.SqlUtils.save(SqlUtils.java:268)
                                                                                         at com.raizlabs.android.dbflow.structure.ModelAdapter.save(ModelAdapter.java:54)
                                                                                         at com.raizlabs.android.dbflow.structure.BaseModel.save(BaseModel.java:50)
                                                                                         at com.magicmicky.habitrpgwrapper.lib.models.tasks.Task$Adapter.bindToContentValues(Task$Adapter.java:216)
                                                                                         at com.magicmicky.habitrpgwrapper.lib.models.tasks.Task$Adapter.bindToContentValues(Task$Adapter.java:12)
                                                                                         at com.raizlabs.android.dbflow.sql.SqlUtils.update(SqlUtils.java:288)
                                                                                         at com.raizlabs.android.dbflow.sql.SqlUtils.save(SqlUtils.java:264)
                                                                                         at com.raizlabs.android.dbflow.structure.ModelAdapter.save(ModelAdapter.java:54)
                                                                                         at com.magicmicky.habitrpgwrapper.lib.models.tasks.Task$Adapter.save(Task$Adapter.java:524)
                                                                                         at com.magicmicky.habitrpgwrapper.lib.models.tasks.Task$Adapter.save(Task$Adapter.java:12)
                                                                                         at com.raizlabs.android.dbflow.structure.BaseModel.save(BaseModel.java:50)
                                                                                         at com.magicmicky.habitrpgwrapper.lib.models.tasks.Task.save(Task.java:364)
                                                                                         at com.habitrpg.android.habitica.callbacks.TaskUpdateCallback.success(TaskUpdateCallback.java:22)
                                                                                         at com.habitrpg.android.habitica.callbacks.TaskUpdateCallback.success(TaskUpdateCallback.java:18)
                                                                                         at retrofit.CallbackRunnable$1.run(CallbackRunnable.java:45)
                                                                                         at android.os.Handler.handleCallback(Handler.java:733)
                                                                                         at android.os.Handler.dispatchMessage(Handler.java:95)
                                                                                         at android.os.Looper.loop(Looper.java:136)
                                                                                         at android.app.ActivityThread.main(ActivityThread.java:5001)
                                                                                         at java.lang.reflect.Method.invokeNative(Native Method)
                                                                                         at java.lang.reflect.Method.invoke(Method.java:515)
                                                                                         at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:785)
                                                                                         at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:601)
                                                                                         at dalvik.system.NativeStart.main(Native Method)

[negue]

@franzejr thats crash seems to be because of me, it has nothing to do with this issue

[franzejr]

@negue , I saw you have created another issue. Should we close this one ?

[negue]

nope its just a different one

[franzejr]

@Viirus , @negue, @MagicMicky

Something I figured out:

1. Open the app
2. Go to TODO
3. Click on Todo
4. Open the TaskFormActivity
5. Go back and it increases like 20Mb of my Android emulator

Memory graphic:

After some sequence doing like this:

I think this problem is something related what I'm facing here: #53 On #53 Once I save a checkList on the TaskForm and I go back to the MainActivity, it saves a lot of elements..Something weird.

PS: To test that I've used the ExcludeCheckListItem annotation (I think this was other motive it was increasing the memory and it does a stack overflow.

[phillipthelen]

Don't think this is related to the crash. Also can't seem to reproduce this on my device? It does allocate quite some memory, but deallocates everything when it's closed again.

[franzejr]

Hm...I will try to reproduce it again(I've reproduced some times before posting it here) without the ExcludeCheckListItem annotation, probably this is getting this issue and then I'm having this because of this annotation or something like this. What do you think it's causing this crash(the original one) ?

[phillipthelen]

I can't reproduce the crash right now either. Potentially it's fixed by some of the edits I made to task updates

[franzejr]

Ok, I will try it again and post it here soon! I remembered the duplicated elements on #53 was before the Annotation, so, I think it was not because of the annotation.

[franzejr]

@Viirus, I just did it again. I got the same error. I've updated my branch, I'm not using nothing about the Annotation, it's totally equal the develop branch. Some problem working if I use dailies rather than TODOS.

I've recorded my screen and you can see it here:

https://youtu.be/OirWDvFjmxQ

I'm using Genymotion with Nexus 6. Should I try in another device ?

[phillipthelen]

The saving behaves quite different from the way it does on develop. (Or at least for me on develop? ) it kind of looks like it instantiates a new mainsctivity? Because the header animates and it displays habits. Instead it should only display the changed task and not update/reload everything. Not sure if this is caused by differences in the branches (as the sevelop code behaved the same and reloaded everything up until two days ago or so) or genymotion doing something strange.

Sent from my iPhone

On 30 Nov 2015, at 02:15, Franzé Jr. notifications@github.com wrote:

@Viirus, I just did it again. I got the same error. I've updated my branch, I'm not using nothing about the Annotation, it's totally equal the develop branch.

I've recorded my screen and you can see it here:

https://youtu.be/OirWDvFjmxQ

I'm using Genymotion with Nexus 6. Should I try in another device ?

—
Reply to this email directly or view it on GitHub.

[franzejr]

I'm on the develop branch, I made another video which I re-install the application and I make sure in the video I'm working on the develop branch, also I make sure it was the last commit on the develop branch.

You can check the second video here: https://youtu.be/WU4nQnEJHSI

My genymotion is a Nexus 6 running with Android 5.

[franzejr]

Even on a Nexus 4 (now testing on Nexus 4) it looks like more stable, after some time, it also increases the memory amount as you can see here: https://youtu.be/VYm34PxDqmA

[franzejr]

@Viirus, your commit here : 60d68ef

Solved the problem! 🎱

Now, you can see the graphic:

I've opened and closed the daily several times.