Purify fix #58
Merged
Purify fix #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @CraigInches , I'll upload a new version to the stores as soon as the other PRs get merged. If you have an Habitica username I'll be happy to award a contribution tier for the PR! |
|
@paglias I am Morat on Habitica :) glad to help edit by Alys 2020-06-06: Just noting for the record here: User ID 8b819da9-81e7-42e4-992e-cd1a9c3a823b in case we need to refer back in future if the Username changes. :) |
|
thanks @CraigInches ! Noted towards your 2nd tier |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DOMPurify santiization was applied widely, but it actually removed functions to make the client work. I modified to sanitize the variables, but static html is left untouched.
Fixes #55