Stripe refactor to lib (#8417)

* Moved stripe tests to folder

* Abstracted stripe payments logic to lib

* Added initial unit test for stripe payment

* Added subscription tests

* Added tests for regulare purchases

* Added tests for edit subscription

* Added cancel tests

* Added integration tests

* Fixed lint issues

* Fixed lint issue

test/api/v3/integration/payments/stripe/GET-payments_stripe_subscribe_cancel.test.js

@@ -0,0 +1,74 @@
+import {
+  generateUser,
+  generateGroup,
+  translate as t,
+} from '../../../../../helpers/api-integration/v3';
+import stripePayments from '../../../../../../website/server/libs/stripePayments';
+
+describe('payments - stripe - #subscribeCancel', () => {
+  let endpoint = '/stripe/subscribe/cancel';
+  let user, group, stripeCancelSubscriptionStub;
+
+  beforeEach(async () => {
+    user = await generateUser();
+  });
+
+  it('verifies credentials', async () => {
+    await expect(user.get(endpoint)).to.eventually.be.rejected.and.eql({
+      code: 401,
+      error: 'NotAuthorized',
+      message: t('missingSubscription'),
+    });
+  });
+
+  describe('success', () => {
+    beforeEach(async () => {
+      stripeCancelSubscriptionStub = sinon.stub(stripePayments, 'cancelSubscription').returnsPromise().resolves({});
+    });
+
+    afterEach(() => {
+      stripePayments.cancelSubscription.restore();
+    });
+
+    it('cancels a user subscription', async () => {
+      user = await generateUser({
+        'profile.name': 'sender',
+        'purchased.plan.customerId': 'customer-id',
+        'purchased.plan.planId': 'basic_3mo',
+        'purchased.plan.lastBillingDate': new Date(),
+        balance: 2,
+      });
+
+      await user.get(`${endpoint}?redirect=none`);
+
+      expect(stripeCancelSubscriptionStub).to.be.calledOnce;
+      expect(stripeCancelSubscriptionStub.args[0][0].user._id).to.eql(user._id);
+      expect(stripeCancelSubscriptionStub.args[0][0].groupId).to.eql(undefined);
+    });
+
+    it('cancels a group subscription', async () => {
+      user = await generateUser({
+        'profile.name': 'sender',
+        'purchased.plan.customerId': 'customer-id',
+        'purchased.plan.planId': 'basic_3mo',
+        'purchased.plan.lastBillingDate': new Date(),
+        balance: 2,
+      });
+
+      group = await generateGroup(user, {
+        name: 'test group',
+        type: 'guild',
+        privacy: 'public',
+        'purchased.plan.customerId': 'customer-id',
+        'purchased.plan.planId': 'basic_3mo',
+        'purchased.plan.lastBillingDate': new Date(),
+      });
+
+      await user.get(`${endpoint}?groupId=${group._id}&redirect=none`);
+
+      expect(stripeCancelSubscriptionStub).to.be.calledOnce;
+      expect(stripeCancelSubscriptionStub.args[0][0].user._id).to.eql(user._id);
+      expect(stripeCancelSubscriptionStub.args[0][0].groupId).to.eql(group._id);
+    });
+  });
+});

test/api/v3/integration/payments/stripe/POST-payments_stripe_checkout.test.js

@@ -0,0 +1,75 @@
+import {
+  generateUser,
+  generateGroup,
+} from '../../../../../helpers/api-integration/v3';
+import stripePayments from '../../../../../../website/server/libs/stripePayments';
+
+describe('payments - stripe - #checkout', () => {
+  let endpoint = '/stripe/checkout';
+  let user, group;
+
+  beforeEach(async () => {
+    user = await generateUser();
+  });
+
+  it('verifies credentials', async () => {
+    await expect(user.post(endpoint, {id: 123})).to.eventually.be.rejected.and.eql({
+      code: 401,
+      error: 'Error',
+      message: 'Invalid API Key provided: ****************************1111',
+    });
+  });
+
+  describe('success', () => {
+    let stripeCheckoutSubscriptionStub;
+
+    beforeEach(async () => {
+      stripeCheckoutSubscriptionStub = sinon.stub(stripePayments, 'checkout').returnsPromise().resolves({});
+    });
+
+    afterEach(() => {
+      stripePayments.checkout.restore();
+    });
+
+    it('cancels a user subscription', async () => {
+      user = await generateUser({
+        'profile.name': 'sender',
+        'purchased.plan.customerId': 'customer-id',
+        'purchased.plan.planId': 'basic_3mo',
+        'purchased.plan.lastBillingDate': new Date(),
+        balance: 2,
+      });
+
+      await user.post(endpoint);
+
+      expect(stripeCheckoutSubscriptionStub).to.be.calledOnce;
+      expect(stripeCheckoutSubscriptionStub.args[0][0].user._id).to.eql(user._id);
+      expect(stripeCheckoutSubscriptionStub.args[0][0].groupId).to.eql(undefined);
+    });
+
+    it('cancels a group subscription', async () => {
+      user = await generateUser({
+        'profile.name': 'sender',
+        'purchased.plan.customerId': 'customer-id',
+        'purchased.plan.planId': 'basic_3mo',
+        'purchased.plan.lastBillingDate': new Date(),
+        balance: 2,
+      });
+
+      group = await generateGroup(user, {
+        name: 'test group',
+        type: 'guild',
+        privacy: 'public',
+        'purchased.plan.customerId': 'customer-id',
+        'purchased.plan.planId': 'basic_3mo',
+        'purchased.plan.lastBillingDate': new Date(),
+      });
+
+      await user.post(`${endpoint}?groupId=${group._id}`);
+
+      expect(stripeCheckoutSubscriptionStub).to.be.calledOnce;
+      expect(stripeCheckoutSubscriptionStub.args[0][0].user._id).to.eql(user._id);
+      expect(stripeCheckoutSubscriptionStub.args[0][0].groupId).to.eql(group._id);
+    });
+  });
+});

test/api/v3/integration/payments/stripe/POST-payments_stripe_subscribe_edit.test.js

@@ -0,0 +1,78 @@
+import {
+  generateUser,
+  generateGroup,
+  translate as t,
+} from '../../../../../helpers/api-integration/v3';
+import stripePayments from '../../../../../../website/server/libs/stripePayments';
+
+describe('payments - stripe - #subscribeEdit', () => {
+  let endpoint = '/stripe/subscribe/edit';
+  let user, group;
+
+  beforeEach(async () => {
+    user = await generateUser();
+  });
+
+  it('verifies credentials', async () => {
+    await expect(user.post(endpoint)).to.eventually.be.rejected.and.eql({
+      code: 401,
+      error: 'NotAuthorized',
+      message: t('missingSubscription'),
+    });
+  });
+
+  describe('success', () => {
+    let stripeEditSubscriptionStub;
+
+    beforeEach(async () => {
+      stripeEditSubscriptionStub = sinon.stub(stripePayments, 'editSubscription').returnsPromise().resolves({});
+    });
+
+    afterEach(() => {
+      stripePayments.editSubscription.restore();
+    });
+
+    it('cancels a user subscription', async () => {
+      user = await generateUser({
+        'profile.name': 'sender',
+        'purchased.plan.customerId': 'customer-id',
+        'purchased.plan.planId': 'basic_3mo',
+        'purchased.plan.lastBillingDate': new Date(),
+        balance: 2,
+      });
+
+      await user.post(endpoint);
+
+      expect(stripeEditSubscriptionStub).to.be.calledOnce;
+      expect(stripeEditSubscriptionStub.args[0][0].user._id).to.eql(user._id);
+      expect(stripeEditSubscriptionStub.args[0][0].groupId).to.eql(undefined);
+    });
+
+    it('cancels a group subscription', async () => {
+      user = await generateUser({
+        'profile.name': 'sender',
+        'purchased.plan.customerId': 'customer-id',
+        'purchased.plan.planId': 'basic_3mo',
+        'purchased.plan.lastBillingDate': new Date(),
+        balance: 2,
+      });
+
+      group = await generateGroup(user, {
+        name: 'test group',
+        type: 'guild',
+        privacy: 'public',
+        'purchased.plan.customerId': 'customer-id',
+        'purchased.plan.planId': 'basic_3mo',
+        'purchased.plan.lastBillingDate': new Date(),
+      });
+
+      await user.post(endpoint, {
+        groupId: group._id,
+      });
+
+      expect(stripeEditSubscriptionStub).to.be.calledOnce;
+      expect(stripeEditSubscriptionStub.args[0][0].user._id).to.eql(user._id);
+      expect(stripeEditSubscriptionStub.args[0][0].groupId).to.eql(group._id);
+    });
+  });
+});

test/api/v3/unit/libs/payments.test.js

@@ -817,59 +817,4 @@ describe('payments/index', () => {
       expect(updatedGroup.purchased.plan.quantity).to.eql(3);
     });
   });
-
-  describe('payWithStripe', () => {
-    let spy;
-    let stripeCreateCustomerSpy;
-    let createSubSpy;
-
-    beforeEach(function () {
-      spy = sinon.stub(stripe.subscriptions, 'update');
-      spy.returnsPromise().resolves;
-
-      stripeCreateCustomerSpy = sinon.stub(stripe.customers, 'create');
-      let stripCustomerResponse = {
-        subscriptions: {
-          data: [{id: 'test-id'}],
-        },
-      };
-      stripeCreateCustomerSpy.returnsPromise().resolves(stripCustomerResponse);
-
-      createSubSpy = sinon.stub(api, 'createSubscription');
-      createSubSpy.returnsPromise().resolves({});
-
-      data.groupId = group._id;
-      data.sub.quantity = 3;
-    });
-
-    afterEach(function () {
-      sinon.restore(stripe.subscriptions.update);
-      stripe.customers.create.restore();
-      api.createSubscription.restore();
-    });
-
-    it('subscribes with stripe', async () => {
-      let token = 'test-token';
-      let gift;
-      let sub = data.sub;
-      let groupId = group._id;
-      let email = 'test@test.com';
-      let headers = {};
-      let coupon;
-
-      await api.payWithStripe({
-        token,
-        user,
-        gift,
-        sub,
-        groupId,
-        email,
-        headers,
-        coupon,
-      }, stripe);
-
-      expect(stripeCreateCustomerSpy.calledOnce).to.be.true;
-      expect(createSubSpy.calledOnce).to.be.true;
-    });
-  });
 });