WIP - prevent multiple notifications

test/api/v3/integration/notifications/prevent-multiple-notification.js

@@ -0,0 +1,33 @@
+import {
+  createAndPopulateGroup,
+} from '../../../../helpers/api-integration/v3';
+
+describe('Prevent multiple notifications', () => {
+  let partyLeader, partyMembers, party;
+
+  before(async () => {
+    let { group, groupLeader, members } = await createAndPopulateGroup({
+      groupDetails: {
+        type: 'party',
+        privacy: 'private',
+      },
+      members: 4,
+    });
+
+    party = group;
+    partyLeader = groupLeader;
+    partyMembers = members;
+  });
+
+
+  it('does not add the same notification twice', async () => {
+    await partyMembers[0].post(`/groups/${party._id}/chat`, { message: 'Message 1'});
+    await partyMembers[1].post(`/groups/${party._id}/chat`, { message: 'Message 2'});
+    await partyMembers[2].post(`/groups/${party._id}/chat`, { message: 'Message 3'});
+    await partyMembers[3].post(`/groups/${party._id}/chat`, { message: 'Message 4'});
+
+    const userWithNotification = await partyLeader.get('/user');
+
+    expect(userWithNotification.notifications.length).to.be.eq(1);
+  });
+});

website/server/models/user/methods.js

@@ -7,8 +7,8 @@ import {
   model as Group,
 } from '../group';
 
-import { defaults, map, flatten, flow, compact, uniq, partialRight } from 'lodash';
-import { model as UserNotification } from '../userNotification';
+import {defaults, map, flatten, flow, compact, uniq, partialRight, filter, isEqual} from 'lodash';
+import {model as UserNotification} from '../userNotification';
 import schema from './schema';
 import payments from '../../libs/payments/payments';
 import amazonPayments from '../../libs/payments/amazon';
@@ -150,11 +150,17 @@ schema.methods.sendMessage = async function sendMessage (userToReceiveMessage, o
  * @param  seen  If the notification should be marked as seen
  */
 schema.methods.addNotification = function addUserNotification (type, data = {}, seen = false) {
-  this.notifications.push({
-    type,
-    data,
-    seen,
-  });
+  // only check if chat notification exists
+  const notifactionAlreadyExists = type === 'NEW_CHAT_MESSAGE' ?
+    filter(this.notifications, n => n.type === type && isEqual(n.data, data)) : -1;
+
+  if (notifactionAlreadyExists === -1) {
+    this.notifications.push({
+      type,
+      data,
+      seen,
+    });
+  }
 };
 
 /**