remove buyMysterySet confirm request

HabitRPG · Jan 28, 2018 · 86bfe36 · 86bfe36
1 parent e7917b4
commit 86bfe36
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 20 deletions.
diff --git a/test/common/ops/buy/buyMysterySet.js b/test/common/ops/buy/buyMysterySet.js
@@ -14,7 +14,6 @@ import i18n from '../../../../website/common/script/i18n';
 describe('shared.ops.buyMysterySet', () => {
   let user;
   let analytics = {track () {}};
-  global.window = {confirm () {}};
 
   beforeEach(() => {
     user = generateUser({
@@ -27,12 +26,10 @@ describe('shared.ops.buyMysterySet', () => {
       },
     });
     sinon.stub(analytics, 'track');
-    sinon.stub(global.window, 'confirm', () => true);
   });
 
   afterEach(() => {
     analytics.track.restore();
-    global.window.confirm.restore();
   });
 
   context('Mystery Sets', () => {
@@ -80,17 +77,6 @@ describe('shared.ops.buyMysterySet', () => {
     });
 
     context('successful purchases', () => {
-      it('does not buy without confirmation', () => {
-        global.window.confirm.restore();
-        sinon.stub(global.window, 'confirm', () => false);
-
-        user.purchased.plan.consecutive.trinkets = 1;
-        buyMysterySet(user, {params: {key: '301404'}}, analytics);
-
-        expect(user.purchased.plan.consecutive.trinkets).to.eql(1);
-        expect(user.items.gear.owned).not.to.have.property('weapon_mystery_301404');
-      });
-
       it('buys Steampunk Accessories Set', () => {
         user.purchased.plan.consecutive.trinkets = 1;
         buyMysterySet(user, {params: {key: '301404'}}, analytics);
@@ -102,7 +88,6 @@ describe('shared.ops.buyMysterySet', () => {
         expect(user.items.gear.owned).to.have.property('head_mystery_301404', true);
         expect(user.items.gear.owned).to.have.property('eyewear_mystery_301404', true);
         expect(analytics.track).to.be.called;
-        expect(global.window.confirm).to.be.called;
       });
     });
   });

diff --git a/website/client/store/actions/shops.js b/website/client/store/actions/shops.js
@@ -82,7 +82,7 @@ export function purchase (store, params) {
 
 export function purchaseMysterySet (store, params) {
   const user = store.state.user.data;
-  let opResult = buyOp(user, {params, noConfirm: true, type: 'mystery'});
+  let opResult = buyOp(user, {params, type: 'mystery'});
 
   return {
     result: opResult,

diff --git a/website/common/script/ops/buy/buyMysterySet.js b/website/common/script/ops/buy/buyMysterySet.js
@@ -23,10 +23,6 @@ module.exports = function buyMysterySet (user, req = {}, analytics) {
     throw new NotFound(i18n.t('mysterySetNotFound', req.language));
   }
 
-  if (!req.noConfirm && window.confirm) { // TODO move to client
-    if (!window.confirm(i18n.t('hourglassBuyEquipSetConfirm'))) return;
-  }
-
   each(mysterySet.items, item => {
     user.items.gear.owned[item.key] = true;
     if (analytics) {