You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When the quest owner or party leader cancels a quest that's still in the invitation phase, there's no indication for other party members that that's what happened and it can lead to confusion (there was a recent bug report from someone who understandably thought that something had gone wrong with the quest).
There should be a message posted to party chat to say, for example, "Alys cancelled the party quest Vice, Part 1: Free Yourself of the Dragon's Influence."
A similar message already exists for the case where a running quest is aborted so similar code could be used for this issue:
$ git grep "the party quest"
test/api/v3/integration/quests/POST-groups_groupid_quests_abort.test.js:130: expect(Group.prototype.sendChat).to.be.calledWithMatch(/aborted the party quest Wail of the Whale.`/);
website/server/controllers/api-v3/quests.js:425: const newChatMessage = group.sendChat(`\`${user.profile.name} aborted the party quest ${questName}.\``);
/code/habitica 2048 $
Also, as part of the fix for this issue, please change the comment shown below to remove (see questCancel for BEFORE) because the function it refers to is now called cancelQuest and it's likely that we'll forget to update the comment if we rename it again :)
* Add message of cancelled quest in party chat
Issue #11093
* Delete trailing spaces
For successful passing the test
* Add test of cancelled quest's message
Also, added an explanation that partyMembers[1] hasn't accepted the invitation in the 'cancels a quest' test
* Fix: import Group
Import Group to pass Lint syntax test
* Move save function to Promise.all
* Fix moving save to Promise.all
When the quest owner or party leader cancels a quest that's still in the invitation phase, there's no indication for other party members that that's what happened and it can lead to confusion (there was a recent bug report from someone who understandably thought that something had gone wrong with the quest).
There should be a message posted to party chat to say, for example, "Alys cancelled the party quest Vice, Part 1: Free Yourself of the Dragon's Influence."
A similar message already exists for the case where a running quest is aborted so similar code could be used for this issue:
Also, as part of the fix for this issue, please change the comment shown below to remove
(see questCancel for BEFORE)
because the function it refers to is now calledcancelQuest
and it's likely that we'll forget to update the comment if we rename it again :)habitica/website/server/controllers/api-v3/quests.js
Line 408 in a2261e3
The text was updated successfully, but these errors were encountered: