Orb of Rebirth remains non-free an extra day (creates misleading message on website)

[Alys]

When the Orb of Rebirth stopped being free consistently from level 100, it was announced in the Aspiring Socialites guild with this message (emphasis is mine):

"Hey Socialites! We deployed a tweak with this Gala that power users might run into. Previously, there was a sort of exploit where folks could use Fix Character Values + the Orb of Rebirth to evade having to pay Gems to change classes. Now, the freebie level 100+ Rebirth is only usable once every 45 days. Users who are affected by the limitation will see a small orange banner when they open the Orb from the Market saying how many days are left in this countdown."

However with the current code, it actually becomes free again after 46 days, not 45. I realise this is pretty minor but it would be easy to fix, and it's causing a misleading display message on the website (described below).

The current API code is this:

habitica/website/common/script/libs/isFreeRebirth.js

Lines 4 to 14 in 2bfc41b

	module.exports = function isFreeRebirth (user) {
	let daysFromLastFreeRebirth = user.flags.lastFreeRebirth;
	if (daysFromLastFreeRebirth) {
	daysFromLastFreeRebirth = moment().diff(moment(user.flags.lastFreeRebirth), 'days');
	} else {
	daysFromLastFreeRebirth = 999;
	}
	return user.stats.lvl >= MAX_LEVEL && daysFromLastFreeRebirth > 45;
	};

It could be changed to match the official announcement by changing > 45 to >= 45

---

The website's behaviour matches the API (i.e., it shows the Orb as free or not free according to the decision made by the API), but because the API makes you wait one extra day, the website's message is confusing on the final day (the day when it should already be free again) - on that day the website says "0 days until FREE Orb of Rebirth", as reported by @Evil_Overmom (0396e6e1-0edc-46f5-9449-24891ba16698):

"Hi -- I'm having a problem with the orb of rebirth. It tells me I have 0 days til I get a free orb, but no option to get the free orb.

If the API's code is fixed as described above, then the Orb will become available a day earlier and you'll never see that misleading message.

FYI this is the website's code but it does not need to be changed if the API change above is made:

habitica/website/client/components/shops/buyModal.vue

Lines 382 to 384 in 2bfc41b

	nextFreeRebirth () {
	return 45 - moment().diff(moment(this.user.flags.lastFreeRebirth), 'days');
	},

habitica/website/client/components/shops/buyModal.vue

Lines 82 to 85 in 2bfc41b

	.free-rebirth.d-flex.align-items-center(v-if='item.key === "rebirth_orb" && item.value > 0 && user.stats.lvl >= 100')
	.m-auto
	span.svg-icon.inline.icon-16.mr-2.pt-015(v-html="icons.whiteClock")
	span(v-html='$t("nextFreeRebirth", {days: nextFreeRebirth})')

[martineizayaga]

@Alys can I be assigned to this issue? I want to work on this

[Alys]

@martineizayaga Sure, thank you! Please go ahead. Comment here if you have questions.

[anushkajj]

Hi! Beginner here. Can I work on this issue?

[Alys]

@martineizayaga how are you going with this? Would you like to keep working on it? If you've become too busy just let us know - we know what that's like. :)

[martineizayaga]

Hi! I would like to keep working on it if that's ok

…

On Sep 8, 2019, 1:58 AM -0400, Alys ***@***.***>, wrote: @martineizayaga how are you going with this? Would you like to keep working on it? If you've become too busy just let us know - we know what that's like. :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[Alys]

@martineizayaga Sure, carry on, thanks! :)

@anushkajj I'm sorry, no, this issue is taken. :)

[anushkajj]

@Alys No issues! Thank you :)

[bmasetto]

@martineizayaga, do you still working on it? I've passed the last couple days reading about how to contribute with Habitica project and now I'm excited to solve my first issue in the project . If you happen too busy to go on with this issue, I could take it for me :)

[Alys]

@martineizayaga Is it okay with you if @bmasetto takes this over?

[martineizayaga]

Yes, please!

[Alys]

@martineizayaga Thanks!

@bmasetto Please go ahead if you're still interested!

[mistergij]

@bmasetto, are you still working on this? I am new to Habitica, and also excited to solve my first project. If you don't mind, I could take it off your hands.

[bmasetto]

For sure, @mistergij! Unfortunately, I was not able to start solving this issue 😞

If @Alys agree, go ahead 😃

[Alys]

@mistergij and @bmasetto Thanks! @mistergij you're welcome to work on this.

[mistergij]

@Alys, created a pull request, waiting for confirmation.

[mistergij]

#11505

[binamkayastha]

Out of curiosity how would you test something like this? Is there a way to award yourself gems in dev and speed up time (Skip to 45 days)?

[Alys]

@mistergij Thanks! Just so you know, you don't need to post to the issue to tell us when you've created a pull request. :) Instead, in your pull request, you can write "Fixes #11297" (that's the issue number) - you put that in the top post in the pull request (the PR template has a comment there as a reminder). That makes an automatic link between the pull request and issue, and then if the pull request is accepted, the issue will be closed automatically. See Using Your Local Install to Modify Habitica%27s Website and API > "Submitting your Change for Review in a Pull Request" for more details about what you can add to your PR. You should include your User ID too so that you can be given credit towards a contributor tier if your PR is accepted. You can edit your PR's top comment if you want to add those things now.

@binamkayastha Yes, you can give yourself Gems, using the Debug menu in the footer (see Using Your Local Install to Modify Habitica%27s Website and API > "Testing your Change Manually" for details).
To speed up time you could adjust the time on your PC, or you could use database commands (see Guidance for Blacksmiths > "MongoDB") to change the date stored in flags.lastFreeRebirth in your test user account.