Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(export) - Issue 12482 - Fix messages in xml export. #12592

Merged
merged 3 commits into from
Sep 25, 2020
Merged

fix(export) - Issue 12482 - Fix messages in xml export. #12592

merged 3 commits into from
Sep 25, 2020

Conversation

benkelaar
Copy link
Contributor

@benkelaar benkelaar commented Sep 20, 2020 •
edited
Loading

Fixes #12482

Changes

  • For XML export, convert ID-keyed newMessages object to list of objects with ID as field.

UUID: d71d2c57-a73d-4591-b64d-e688584a9092

@benkelaar benkelaar force-pushed the 12482-xml-export branch 2 times, most recently from 2592171 to b19f7f0 Compare September 24, 2020 04:58
@benkelaar
Copy link
Contributor Author

@paglias Ready for review again. Ideally I'd add test-cases for the other corner cases in the library, but I'm late for work 😁 .

@paglias paglias merged commit 025b994 into HabitRPG:develop Sep 25, 2020
@paglias
Copy link
Contributor

paglias commented Sep 25, 2020

thanks @benkelaar ! Noted in your profile

@benkelaar benkelaar deleted the 12482-xml-export branch September 25, 2020 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paglias paglias paglias left review comments

@Alys Alys Alys left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data Export Erroring Out
4 participants
@benkelaar @paglias @Alys @SabreCat