New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infinite gold #47
Comments
Lol! Don't you people know the Konami code? Jk, i'll fix this thanks. |
When you get all that wonderful negative gold... and buy everything... There's a blank for armor and weapons above gold level. That was fun... |
If this is still an open issue I'll tackle it tomorrow. |
It is. All I think that needs to be done is to remove being able to add a negative number as a reward. |
@Andrew565 check out https://github.com/chriso/node-validator while you're in there. |
We could use: money -= Math.abs(taskObj.value) in the scoring.coffee file to have the reward always cost gold until we work out the validation. Edit: OK. I think I uploaded the files correctly. That should fix it and stop any more free gold from getting out. |
I hope @lefnire can get a look at this. The question is though, will this also work if we put in "asdfs" ? So far this caused the GP counter to become NaN and this means buy whatever you like until a day reset ;) It would also be nice to have something like this while setting the value. I don't know about the syntax but something like: money = Math.abs(taskObj.value) |
It reverts back to the unedited value if a non-number is entered and gives a tooltip with an error when a negative value is entered. |
Is this included in your pull request :) ? |
Yes. My update should fix it. |
Cool :) Well then I hope Tyler can take a look at your pull request soon :) On Mon, Feb 4, 2013 at 11:18 PM, Sabin144 notifications@github.com wrote:
|
merged, will go out with the next push. @Pandoro, once I get some proper accessControl in I'll build some debug tools for us - maybe activated by the Konami Code ;) |
Checking and unchecking a daily will produce infinite gold, albeit in small increments. |
Adding to what tjwds said, you can also keep all the item drops from clicking and unclicking the dailies. Includes pets, food, crits, and hatching potions. (Crits meaning that critical hits will keep the difference in exp too.) |
That's not an issue wrt drops, considering there's a drop cap. I'm also not On Thu, Apr 24, 2014 at 10:23 PM, lcnv notifications@github.com wrote:
|
Draft of names, descriptions, stats, and costs for class-based equipment
You can set negative cast for reward and gain as much gold as you want
The text was updated successfully, but these errors were encountered: