Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite gold #47

Closed
JleruOHeP opened this issue Jan 10, 2013 · 15 comments
Closed

Infinite gold #47

JleruOHeP opened this issue Jan 10, 2013 · 15 comments

Comments

@JleruOHeP
Copy link

You can set negative cast for reward and gain as much gold as you want

@lefnire
Copy link
Contributor

lefnire commented Jan 10, 2013

Lol! Don't you people know the Konami code? Jk, i'll fix this thanks.

@hookang
Copy link

hookang commented Jan 14, 2013

When you get all that wonderful negative gold... and buy everything...

There's a blank for armor and weapons above gold level.

That was fun...

@Andrew565
Copy link
Contributor

If this is still an open issue I'll tackle it tomorrow.

@hookang
Copy link

hookang commented Jan 22, 2013

It is. All I think that needs to be done is to remove being able to add a negative number as a reward.

@lefnire
Copy link
Contributor

lefnire commented Jan 22, 2013

@Andrew565 check out https://github.com/chriso/node-validator while you're in there.

@dbueller
Copy link
Contributor

dbueller commented Feb 4, 2013

We could use:

money -= Math.abs(taskObj.value)

in the scoring.coffee file to have the reward always cost gold until we work out the validation.

Edit: OK. I think I uploaded the files correctly. That should fix it and stop any more free gold from getting out.

@Pandoro
Copy link

Pandoro commented Feb 4, 2013

I hope @lefnire can get a look at this. The question is though, will this also work if we put in "asdfs" ?

So far this caused the GP counter to become NaN and this means buy whatever you like until a day reset ;)

It would also be nice to have something like this while setting the value. I don't know about the syntax but something like:

money = Math.abs(taskObj.value)
if(money ==NaN){
//display some error
}else{
// create task
}

@dbueller
Copy link
Contributor

dbueller commented Feb 4, 2013

It reverts back to the unedited value if a non-number is entered and gives a tooltip with an error when a negative value is entered.

@Pandoro
Copy link

Pandoro commented Feb 4, 2013

Is this included in your pull request :) ?

@dbueller
Copy link
Contributor

dbueller commented Feb 4, 2013

Yes. My update should fix it.

@Pandoro
Copy link

Pandoro commented Feb 4, 2013

Cool :) Well then I hope Tyler can take a look at your pull request soon :)
Although I must say the negative gold is Very useful when testing on the
test server ;)

On Mon, Feb 4, 2013 at 11:18 PM, Sabin144 notifications@github.com wrote:

Yes. My update should fix it.


Reply to this email directly or view it on GitHubhttps://github.com//issues/47#issuecomment-13103031.

lefnire added a commit that referenced this issue Feb 4, 2013
@lefnire
Copy link
Contributor

lefnire commented Feb 5, 2013

merged, will go out with the next push. @Pandoro, once I get some proper accessControl in I'll build some debug tools for us - maybe activated by the Konami Code ;)

@lefnire lefnire closed this as completed Feb 5, 2013
@tjwds
Copy link
Contributor

tjwds commented Apr 6, 2014

Checking and unchecking a daily will produce infinite gold, albeit in small increments.

@lcnv
Copy link

lcnv commented Apr 25, 2014

Adding to what tjwds said, you can also keep all the item drops from clicking and unclicking the dailies. Includes pets, food, crits, and hatching potions. (Crits meaning that critical hits will keep the difference in exp too.)

@deilann
Copy link
Contributor

deilann commented Apr 26, 2014

That's not an issue wrt drops, considering there's a drop cap. I'm also not
really concerned about this simply because well, if people are that into
button clicking and missing the point of Habit... they should enjoy their
gold? It would be a lot easier to go into Fix Character Values.

On Thu, Apr 24, 2014 at 10:23 PM, lcnv notifications@github.com wrote:

Adding to what tjwds said, you can also keep all the item drops from
clicking and unclicking the dailies. Includes pets, food, crits, and
hatching potions. (Crits meaning that critical hits will keep the
difference in exp too.)


Reply to this email directly or view it on GitHubhttps://github.com//issues/47#issuecomment-41359885
.

Alys referenced this issue in Alys/habitica Jul 14, 2014
Draft of names, descriptions, stats, and costs for class-based equipment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants