Update conditional render to only show Apply Sort... text in party modals. fixes #10968 #10984
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #10968
Changes
I've gone ahead and modified the conditional render
v-if
code inmembersModal.vue
to only render the "Apply Sort Options to Party Header" link button if the current group is of type 'party'. This group data was already accessible, so no changes needed to be changed to get new data to the page.I've manually tested locally by creating two user accounts, a party, and a guild, making sure that the Apply Sort Options to Party Header link only displays after changing the filter options within a party.
I ran the automated tests (using
npm run test
) on both develop and my new branch and I've attached images of the results. Looks like there are some failing tests ondevelop
that my branch also encounters.Let me know if there's anything else I need to do or am missing on this issue!
UUID: 003b1968-38ba-4bcc-9cf6-25926c4d5f11