Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update conditional render to only show Apply Sort... text in party modals. fixes #10968 #10984

Merged
merged 1 commit into from
Feb 21, 2019
Merged

Update conditional render to only show Apply Sort... text in party modals. fixes #10968 #10984

merged 1 commit into from
Feb 21, 2019

Conversation

CBillings92
Copy link
Contributor

fixes #10968

Changes

I've gone ahead and modified the conditional render v-if code in membersModal.vue to only render the "Apply Sort Options to Party Header" link button if the current group is of type 'party'. This group data was already accessible, so no changes needed to be changed to get new data to the page.

I've manually tested locally by creating two user accounts, a party, and a guild, making sure that the Apply Sort Options to Party Header link only displays after changing the filter options within a party.

I ran the automated tests (using npm run test) on both develop and my new branch and I've attached images of the results. Looks like there are some failing tests on develop that my branch also encounters.

Let me know if there's anything else I need to do or am missing on this issue!


new-branch-failed-tests
failed_tests_develop

UUID: 003b1968-38ba-4bcc-9cf6-25926c4d5f11

@SabreCat
Copy link
Member

Thanks for this, @CBillings92! It'll go into a staging environment now for live testing, then if all is well move to production next week.

Welcome to the ranks of the Blacksmiths at tier 1! Note that further tiers require increasing amounts of effort from one to the next, so tier 2 will take multiple PRs or a larger PR to attain. But keep helping out and we'll express our gratitude accordingly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Apply Sort Options to Party Header" should not appear in Guilds
4 participants