Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix header design #11013

Merged
merged 2 commits into from Mar 4, 2019
Merged

fix header design #11013

merged 2 commits into from Mar 4, 2019

Conversation

negue
Copy link
Member

@negue negue commented Feb 20, 2019

Requested Changes

  • Health, Experience, and Mana bars should have a border-radius of 1px
  • Fix placement of Health, Experience, and Mana bar tooltips (2px under the bar)

In order to change the tooltip position, its only possible to change by the tooltip-class (no ability to add a custom class)

I extracted the progress and tooltip to a custom component, which then could be styled within the container

@paglias
Copy link
Contributor

paglias commented Mar 3, 2019

schermata 2019-03-03 alle 17 20 31

looks like there's a minor problem here with the tooltips appearing under the header

@negue
Copy link
Member Author

negue commented Mar 4, 2019

thanks for catching that one, it was a scss-scope issue

@paglias
Copy link
Contributor

paglias commented Mar 4, 2019

thanks!

@Tressley
Copy link
Collaborator

Tressley commented Mar 8, 2019

These LGTM. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants