Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add min-width to PM for wrapping fixes #11060 #11081

Merged
merged 1 commit into from
Apr 2, 2019

Conversation

randi2kewl
Copy link
Contributor

Fixes #11060

To be honest, I don't really understand why this works... but it does. I got the fix from a discussion on SO that seems to point to it being a bug in Chrome.

Changes

  1. Add min-width to the .d-flex container

Screen Shot 2019-03-23 at 3 19 56 PM

Screen Shot 2019-03-23 at 3 19 43 PM

Screen Shot 2019-03-23 at 3 19 27 PM


UUID: 949c048a-c49b-434a-97af-cc7603082dec

Made with ❤️ by sergeanthacker

@randi2kewl
Copy link
Contributor Author

Browser Tests:

Firefox
Screen Shot 2019-03-23 at 3 25 43 PM

Chrome
Screen Shot 2019-03-23 at 3 24 33 PM

Safari
Screen Shot 2019-03-23 at 3 23 21 PM

@SabreCat
Copy link
Member

I'm doing a bunch of private message refactoring and overhauling in https://github.com/HabitRPG/habitica/compare/sabrecat/inbox-redux (no PR yet), so I'll take a look at this fix and incorporate it there with credit if it's helpful!

@randi2kewl
Copy link
Contributor Author

@SabreCat do you want me to close this PR? I'd hate to add to leave clutter behind me.

@SabreCat
Copy link
Member

SabreCat commented Apr 2, 2019

On further consideration, this is a quick enough win that it can go live prior to that work, which is turning out to be quite the overhaul. Credited toward your 3rd contributor tier, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

long URLs in Inbox / private messages can prevent PMs wrapping correctly
2 participants