Only includes backticks if they haven't been already included. Fixes … #11250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Scens and thanks for the PR! Sorry for the delay here but we'll review the pr soon |
paglias
suggested changes
Jul 9, 2019
Thanks! You are right, I have taken care of these. I've tested this again and everything works fine. |
paglias
added
status: pr: tested and approved; merge pending
and removed
status: pr: ready for review
labels
SabreCat
added
status: pr: merged in develop; deploy pending
and removed
status: pr: tested and approved; merge pending
labels
|
Thanks, @Scens! This will go live on the production site around this time next week. Credited toward your second Blacksmith tier! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…the problem.
Fixes #11202
Changes
Affects only messages created by translateMessage function in /website/server/libs/chat/group-chat.js. There doesn't seem to be any other case of displaying double backticks.
Code only includes backticks if they haven't been already included (because they might have been hardcoded in questContent.json).
UUID: dd59e7c1-b76a-466e-b301-783b852da699