Removed loading screen tips, fixes #11834

[anoopravella]

Fixes #11834

Removed the div that displayed tips on the loading screen from the app.vue file. Also removed the code that selected the random tip to be displayed, also in app.vue.

When I ran the test suite locally, 11 tests failed, but the same 11 tests also failed when I ran them on the develop (untouched) branch locally.

Could not screenshot the change (as per the development guide) because the loading screen finished too quickly.

[paglias]

thanks @anoopravella ! could you also remove the website/common/locales/en/loadingScreenTips.json file as it contains the loading tips that we don't need anymore so that it's not loaded?

@Alys do we want to add a note about the file being removed so that we'll remember it's in the git history if we want to add these back?
@SabreCat quick question about Weblate, when removing a .json file is it okay to remove it only for English? or should it be removed for every language? Not sure how it's handled

[Alys]

do we want to add a note about the file being removed so that we'll remember it's in the git history if we want to add these back?

Good idea! The wiki's Loading Page Tips page already had some information about the code so I've updated that and added a temporary note, linking to the PR (it's all in the Information for Developers section at the bottom - click a button there to reveal it). Once this PR is merged and live, I'll make further changes to the page, and also link to the final commit in develop. I'm labelling this as "notify helpers" as a reminder to me. I'll also want to tell the Socialites so they can answer questions about why the tips were removed.

[paglias]

thanks @anoopravella ! This will go live by the end of the week, if you have an Habitica UUID i'll be happy to award you a contribution tier