Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Issue #12421 - Change page title based on the site section being viewed #12627

Merged
merged 21 commits into from Oct 26, 2020
Merged

Fixes Issue #12421 - Change page title based on the site section being viewed #12627

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
275ba1d
Update title for tabs not including challenges, guild and team
jbusa22 Sep 27, 2020
1387deb
add section titles to challenges, guilds, and groups
jbusa22 Sep 28, 2020
e960433
Merge remote-tracking branch 'upstream/develop' into develop
jbusa22 Sep 28, 2020
02ec305
Update dynamic title to use vuex action
jbusa22 Oct 3, 2020
8b2b9da
Merge branch 'develop' into develop
paglias Oct 5, 2020
68a08a3
Remove duplicate key
jbusa22 Oct 5, 2020
07df907
Merge branch 'develop' of https://github.com/jbusa22/habitica into de…
jbusa22 Oct 5, 2020
9f4ea7f
Actually remove duplicate key
jbusa22 Oct 5, 2020
78b24c4
Fix section sub section in group
jbusa22 Oct 5, 2020
94a7d90
Add note to implement setTitle when adding a page
jbusa22 Oct 5, 2020
575cb01
Add missing sections to dynamic title
jbusa22 Oct 19, 2020
dac2cc7
Features string not translated
jbusa22 Oct 19, 2020
68344e2
Use onGroupUpdate to update group titles
jbusa22 Oct 19, 2020
e8da16f
Add watcher to challenges for dynamic title updates
jbusa22 Oct 19, 2020
2b0307f
Small fixes
jbusa22 Oct 20, 2020
77b54ec
Add register and login to title, remove duplicate keys
jbusa22 Oct 20, 2020
748f5af
Add home page dynamic title functionality
jbusa22 Oct 20, 2020
d2b563c
Minor name changes
jbusa22 Oct 24, 2020
27804aa
Merge branch 'develop' of https://github.com/HabitRPG/habitica into d…
jbusa22 Oct 24, 2020
6559b61
remove wrong i18n strings from front.js
paglias Oct 26, 2020
3915645
refactor router note
paglias Oct 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion website/client/src/components/groups/group.vue
View file
Open in desktop
Expand Up @@ -498,7 +498,8 @@ export default {
if (!this.searchId) this.searchId = this.groupId;
await this.fetchGuild();
this.$store.dispatch('common:setTitle', {
section: this.group.name,
section: this.t$('groupPlans'),
paglias marked this conversation as resolved.
Show resolved Hide resolved
subSection:this.group.name,
paglias marked this conversation as resolved.
Show resolved Hide resolved
});
this.$root.$on('updatedGroup', this.onGroupUpdate);
},
Expand Down
2 changes: 2 additions & 0 deletions website/client/src/router/index.js
View file
Open in desktop
Expand Up @@ -6,6 +6,8 @@ import handleRedirect from './handleRedirect';

import ParentPage from '@/components/parentPage';

// NOTE: when adding a page make sure to implement setTitle

// Static Pages
const StaticWrapper = () => import(/* webpackChunkName: "entry" */'@/components/static/staticWrapper');
const HomePage = () => import(/* webpackChunkName: "entry" */'@/components/static/home');
paglias marked this conversation as resolved.
Show resolved Hide resolved
Expand Down
1 change: 0 additions & 1 deletion website/common/locales/en/groups.json
View file
Open in desktop
Expand Up @@ -41,7 +41,6 @@
"chat": "Chat",
"sendChat": "Send Chat",
"group": "Group",
"groupPlans": "Group Plans",
"groupName": "Group Name",
"groupLeader": "Group Leader",
"groupID": "Group ID",
Expand Down