API Summary Length #12934
Closed
API Summary Length #12934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can't get tests to run on my machine so I'm not really sure why these are failing right now |
|
I would move the check to the model with a validator https://mongoosejs.com/docs/validation.html |
paglias
reviewed
Jan 7, 2021
| @@ -200,6 +205,7 @@ api.createChallenge = { | |||
| const { user } = res.locals; | |||
|
|
|||
| req.checkBody('group', apiError('groupIdRequired')).notEmpty(); | |||
| if (req.body.challenge.summary && req.body.challenge.summary.length > MAX_SUMMARY_SIZE_FOR_CHALLENGES) throw new BadRequest(res.t('summaryTooLong')); | |||
There was a problem hiding this comment.
what if req.body.challenge is not defined? Also this cose should go after the validation errors
|
@thewilloftheshadow the tests are failing because you're not checking for the existence of |
paglias
added
status: pr: with author: needs work
and removed
status: pr: ready for review
labels
|
Got it 👍🏻 |
|
To see the error you have to:
|
|
Ahh that's exactly what I needed! Tyty |
|
Closing this PR as abandoned. Worth peeking at for whoever picks this up next, though! |
SabreCat
added
status: pr: abandoned
and removed
status: pr: with author: needs work
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9244
Changes
API now rejects both new challenge and challenges update if summary is longer than maximum length
Adds tests for this new check
UUID: 2eb203f5-1b1e-4e5d-84a4-22f130a1090e