Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #14563 FAQ translations on the web page #15079

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

umbrella-h
Copy link
Contributor

@umbrella-h umbrella-h commented Jan 3, 2024

Fixes #14563

Changes

In the Vuex store action getFAQ, retrieve the language code from the i18n store state, and include it in the query of the FAQ API GET request.
This modification ensures that the FAQ API request aligns with the user's selected language for internationalization.

(Tested this with Ukrainian)
image


UUID: 67968b90-5b20-45a6-9589-e8055a16cf2a

@umbrella-h umbrella-h changed the title Fixes # 14563 FAQ translations on the web page Fixes #14563 FAQ translations on the web page Jan 3, 2024
@umbrella-h umbrella-h marked this pull request as ready for review January 3, 2024 17:56
@umbrella-h
Copy link
Contributor Author

As a first-time contributor, the test workflow hasn't run automatically. Could an admin please click the button to start it? 🙏🏼

@SabreCat
Copy link
Member

Thanks for this, @umbrella-h, and welcome to the ranks of the Blacksmiths at tier 1!

We'll get this live on the production site within a few days.

@SabreCat SabreCat changed the base branch from develop to release January 10, 2024 23:00
@SabreCat SabreCat merged commit 8b2e13b into HabitRPG:release Jan 10, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FAQ translations do not appear on the web page
2 participants