Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reward:gold field is now a number instead of text. #179

Merged
merged 1 commit into from
Jan 23, 2013

Conversation

pironic
Copy link
Contributor

@pironic pironic commented Jan 22, 2013

changing the field type will validate the input from user before submitting form... we should check the input once received as well, but this is good enough for now...

this is to address #50

…t from user before submitting form... we should check the input once received as well, but this is good enough for now
@superlikelikes
Copy link

i put "vacation" as the value and got a free level up when i clicked it!

@superlikelikes
Copy link

it doesn't work now, though. i did it yesterday.

@pironic
Copy link
Contributor Author

pironic commented Jan 23, 2013

Sorry, I'm confused, I you put vacation yesterday, and and with this new validation it won't accept that any more? Or, you fixed the error yesterday, and now with this new validation, the code you submitted previously doesn't work anymore? Your two sentences could be taken either way...

The code I'm submitting here doesn't handle the error checking at the server, which means that people can still 'game' the the value or force the page to accept negative numbers... But for the majority of the Web users, this is an immediate fix. Plus it makes the field have a little up/down arrow on the side of it...

@superlikelikes
Copy link

habit rewards vacation

I clicked vacation and it gave me an instant level up.
I just thought it was cool.

I'm sorry if I confused you. I'm new.

@superlikelikes
Copy link

Now if i click it, it just takes my coins. Not joking.
Try it :)

@StanLindsey
Copy link
Contributor

This hasn't been committed yet though has it so it shouldn't take any effect on the live site? (Unless you're using dev tools to edit the files live)

lefnire added a commit that referenced this pull request Jan 23, 2013
reward:gold field is now a number instead of text.
@lefnire lefnire merged commit ced8b16 into HabitRPG:master Jan 23, 2013
@lefnire
Copy link
Contributor

lefnire commented Jan 23, 2013

will deploy with next batch of pushes. Awesome awesome @pironic, keep em coming!

@pironic pironic deleted the gold-validate branch January 23, 2013 16:31
Alys referenced this pull request in Alys/habitica Jul 14, 2014
Made Clover-steel Helmet boost strength instead of perception; increased...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants