Made two lines translatable #5251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 21, 2015 17:12
UI strings of the dialog of invitation to the group made translatable
crookedneighbor
added a commit
that referenced
this pull request
May 23, 2015
Made two lines translatable
|
Looks reasonable to me. Notated toward your next tier! |
|
@crookedneighbor Tnank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #.10 and #.11 in the OP of #4522
label)
Screenshot showing line 1 is changable
Screenshot showing line 2 is changable
Screenshot of the result
In addition to Invite Friends button, the dialog behind it needed to be translatable too.
Screenshot of the result for the latter.