Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added hidable markdown help table and added formatting-help to private messages #5268

Merged
merged 2 commits into from
May 25, 2015
Merged

Added hidable markdown help table and added formatting-help to private messages #5268

merged 2 commits into from
May 25, 2015

Conversation

hairlessbear
Copy link
Contributor

This PR uses formatting-help.jade to add a hidden-by-default markdown help table.

selection_012
selection_013

I also added formatting-help to private messages, because why not?

selection_015
selection_014

@hairlessbear
Copy link
Contributor Author

I tried to include only the markdown syntax that users were most likely to find helpful. As you can see in the code, there's a commented out row that has the image inclusion syntax. I opted to remove it because I don't think many users use it, but I kept it in the PR just in case others disagree.

@hairlessbear hairlessbear reopened this May 24, 2015
@hairlessbear hairlessbear changed the title Added hidable markdown help menu and added formatting-help to private messages Added hidable markdown help table and added formatting-help to private messages May 24, 2015
@crookedneighbor
Copy link
Contributor

Looking really good. Made just a few tweaks: 681668f

Here's how it looks now:

screen shot 2015-05-24 at 9 23 45 am

Anyone have other tweaks they want in before I merge?

@hairlessbear
Copy link
Contributor Author

If we aren't including the image syntax, we should remove its commented out row from the table and remove its entries from generic.json.

@deilann
Copy link
Contributor

deilann commented May 25, 2015

I use the image code quite a bit. I'm not entirely sure why we're not
adding it because it's not used a lot. I'd imagine that would be a reason
to add it: users aren't aware it's available.

On Sun, May 24, 2015 at 9:36 AM, hairlessbear notifications@github.com
wrote:

If we aren't including the image syntax, we should remove its commented
out row from the table and remove its entries from generic.json.


Reply to this email directly or view it on GitHub
#5268 (comment).

@crookedneighbor crookedneighbor merged commit 4bc3ea0 into HabitRPG:develop May 25, 2015
@crookedneighbor
Copy link
Contributor

Image example added in. Notated toward your next contributor tier.

@hairlessbear
Copy link
Contributor Author

@crookedneighbor Did you use the image example that I wrote, or modify it? I'm asking because the one I wrote displayed the image at full-size instead of resizing it (like what happens in chat), and it is far too large for the table.

@crookedneighbor
Copy link
Contributor

I modified it and used a small image.

@hairlessbear
Copy link
Contributor Author

Figured as much, just wanted to check. Thanks for the response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants