Export fixes #646
Merged
Export fixes #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evulins
reviewed
May 23, 2024
| }; | ||
|
|
||
| const handleKeyDown = (event: React.KeyboardEvent<HTMLDialogElement>) => { | ||
| if (event.key === "Escape") { |
There was a problem hiding this comment.
I think we can move this to KeyboarKeys.ts
evulins
reviewed
May 23, 2024
app/javascript/react/components/ExportDataModal/ExportDataModal.tsx
Outdated
Show resolved
Hide resolved
evulins
approved these changes
May 23, 2024
jankrzempek
reviewed
May 23, 2024
| @@ -0,0 +1,95 @@ | |||
| import React, { useState, useRef, useEffect } from "react"; | |||
| import { useTranslation } from "react-i18next"; | |||
| import { | |||
There was a problem hiding this comment.
empty line between please 😃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've incorporated Michael's feedback from the comment on this Trello card
Now, when exporting a session, users will find an email input interface positioned just above the button.
Note: Mobile users will still see the previous modal design as per the original specifications."