Feature/sticker finalization #133
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feature/sticker-finalization
…into feature/sticker-finalization
|
Deploy preview for zothacks-site-2023 ready!
|
|
Deploy preview for zothacks-site-2023-sanity ready!
|
|
Personally don't want to include any more stickers besides the heart one because of how much trouble we've had with them, even if we do have a "fix". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Stickers are positioned by anchoring to an existing component. Using API created by @alexanderl19 to place the stickers on the corners of components with offsets.
Details
Refactored components for compatibility. The "responsiveness" of this PR is that the positioning will be off the screen on smaller screens. The stickers are still going to be oddly positioned on window resize. However, on reload, they will be correctly positioned.
The issue before was the initial positioning was done by passing props and putting them into Framer Motion's initial prop. This has issues with SSR, which was the source of the "jumping" on window resize. Moved to inline styles solved this.