Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor branch lookup and redirection code #206

Closed
bunsenmcdubbs opened this issue Mar 6, 2018 · 1 comment · Fixed by #214
Closed

Refactor branch lookup and redirection code #206

bunsenmcdubbs opened this issue Mar 6, 2018 · 1 comment · Fixed by #214
Labels
enhancement Adds or suggests a new feature, rewrite, or other enhancement to the codebase low priority
Milestone
Midsummer HackGT 5

Comments

@bunsenmcdubbs
Copy link
Contributor

bunsenmcdubbs commented Mar 6, 2018 •
edited

The current branch lookup code is ugly (and inefficient but OK). It could be made a lot better with schema changes (lowercased version of all branch names for lookup) or the new collation feature in MongoDB http://plusnconsulting.com/post/MongoDB-Dont-be-so-case-sensitive/

As is, it is also currently bug-prone because it is spaghetti-like.
@bunsenmcdubbs bunsenmcdubbs added enhancement Adds or suggests a new feature, rewrite, or other enhancement to the codebase low priority labels Mar 6, 2018
@petschekr
Copy link
Member

Do you have a link to the file (maybe even line number) where this is for reference @bunsenmcdubbs ?

@bunsenmcdubbs bunsenmcdubbs changed the title Refactor branch lookup code Refactor branch lookup and redirection code Mar 6, 2018
ehsanmasdar added a commit that referenced this issue May 8, 2018
@ehsanmasdar
Various fixes for walk-up registration, including #209/#208, and simp…
2669fcd 
…lification of redirection logic #206
@ehsanmasdar ehsanmasdar mentioned this issue May 8, 2018
Merged
@ehsanmasdar ehsanmasdar modified the milestones: HackGT 5 Updates, HackGT 5, Midsummer HackGT 5 May 15, 2018
@petschekr petschekr removed the pending review This PR is pending review by a maintainer label Jun 29, 2018
rahulrajus pushed a commit that referenced this issue Jul 22, 2021
@ehsanmasdar
Various fixes for walk-up registration, including #209/#208, and simp…
d23cde3 
…lification of redirection logic #206
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Adds or suggests a new feature, rewrite, or other enhancement to the codebase low priority
Projects
None yet
Milestone
Midsummer HackGT 5
Development

Successfully merging a pull request may close this issue.

Confirmation refactor HackGT/registration
3 participants
@bunsenmcdubbs @petschekr @ehsanmasdar