Implement OAuth authentication with GitHub, Google, and Facebook #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petschekr
added
enhancement
There was a problem hiding this comment.
I didn't get a chance to run this but it looks pretty good to me, pretty standard use of passport etc.
@illegalprime take a look at this, I think it's all set 👍
This supplants the previous password-based authentication in place. The routes on /api/user have been removed. New routes on /auth will perform a similar task without being part of the REST API. Other OAuth providers can now be simply dropped into place in a similar manner to GitHub.
Greatly reduces the amount of repetitive code present and makes adding other OAuth providers much simpler and less error prone.
petschekr
force-pushed
the
authentication
branch
from
c5ed557
to
0b82e7b
Compare
Merged
illegalprime
approved these changes
Feb 13, 2017
illegalprime
removed
the
pending review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the previous password-based authentication with simpler OAuth authentication with multiple providers. Currently, these are GitHub, Google, and Facebook but the code is set up to easily allow for additional providers to be added in the future.
This pull request covers mostly server-side changes with only a very basic (and ugly) login page implemented.
If someone reviewing this pull requests want to try out OAuth logins for themselves, they must set up individual application on all three OAuth providers to get client ids and secrets. Alternatively, to save time, just post in the HackGT Slack and I'll send you my
config.jsonwith all of this information already filled out.Closes #9