Anonymous/walk-in registration #205

bunsenmcdubbs · 2018-03-05T21:10:14Z

Closes #194

3 options have been added for application branches in the admin panel

Allow anonymous submissions: - Enables admins to navigate to /register/<branch-name> and register new users without accounts.
Auto-accept applicants - Pretty self-explanatory, any applicants on this branch will be automatically accepted. Two caveats:
1. "Post-accept" emails will no longer be sent. This is intended behavior. Please be sure that any information in a "post-accept" email is in either post-apply or post-confirm emails (including reminding applicants that they need to return to the site to RSVP if confirmation is required).
2. This is not retroactive, any users who submitted their applications to this branch before the option was enabled still need to be manually accepted.
Skip Confirmation - indicates that there is no confirmation step for this application branch. The final stage for applicants in this stage is "accepted". (Implemented by automatically marking users as attending=true without a confirmation branch).

#207 is a follow-up that should be implemented to add full functionality for users created in the "anonymous submission" workflow.

This will enable registration workflow. When all three options are enabled on an application branch.

hackgbot · 2018-03-05T21:12:18Z

Hey y'all! A deployment of this PR can be found here:
https://registration-anonymous-form-submission.pr.hack.gt

bunsenmcdubbs · 2018-03-07T06:22:23Z

…ions

bunsenmcdubbs · 2018-03-07T06:55:56Z

Rebased on top of master (fixed tiny conflict)

bunsenmcdubbs · 2018-03-07T07:00:34Z

View of admin panel with new options.

Top of the anonymous registration view - url: localhost:3000/register/Participant and the user is current an admin user. Email is automatically added when there is no authenticated user. The "sidebar" aka top nav is also hidden when this is the case.

petschekr · 2018-03-09T18:03:55Z

client/application.html

 				</div>
 			</form>
 		{{/sidebar}}
+		<script type="text/javascript">
+		formTypeString = "Application";


WTF is this a global variable?? Remove the type attribute from the <script> tag. If you need a global variable, do window.myVariable = x instead so that it will work in strict mode.

adding it to window won't work because typescript doesn't recognize additional properties on window

petschekr · 2018-03-09T18:04:03Z

client/confirmation.html

@@ -85,5 +85,8 @@ <h1 class="center">RSVP: {{branch}}</h1>
 				</div>
 			</form>
 		{{/sidebar}}
+		<script type="text/javascript">
+		formTypeString = "Confirmation";


Globals again

petschekr · 2018-03-09T18:05:26Z

client/js/admin.ts

@@ -642,6 +645,61 @@ for (let i = 0; i < timeInputs.length; i++) {
 	timeInputs[i].value = moment(new Date(timeInputs[i].dataset.rawValue || "")).format("Y-MM-DDTHH:mm:00");
 }

+// Uncheck available confirmation branches for application branch when "skip confirmation" option is selected
+function uncheckConfirmationBranches(applicationBranch: string) {
+	let checkboxes = document.querySelectorAll(`.branch-role[data-name="${applicationBranch}"] .availableConfirmationBranches input[type="checkbox"]`);


Types will work better here if it's let checkboxes: NodeListOf<HTMLInputElement> = x. Then you don't need the ugly cast on line 652.

Typescript won't allow me to cast NodeListOf<Element> to NodeListOf<HTMLInputElement>

petschekr · 2018-03-09T18:05:41Z

client/js/admin.ts

+		(input as HTMLInputElement).checked = false;
+	}
+}
+let skipConfirmationToggles = document.querySelectorAll(".branch-role input[type=\"checkbox\"].noConfirmation");


Same thing with types

Same thing with how its not possible.

petschekr · 2018-03-09T18:08:27Z

client/js/admin.ts

+		checkbox.click();
+	}
+}
+let availableConfirmationBranchCheckboxes = document.querySelectorAll(".branch-role fieldset.availableConfirmationBranches input[type=\"checkbox\"]");


Better typing

Same thing with how its not possible.

petschekr · 2018-03-09T18:08:37Z

client/js/admin.ts

+
+// Select "skip confirmation" option when "allow anonymous" option is selected
+// Hide/show public link when "allow anonymous" is clicked
+let allowAnonymousCheckboxes = document.querySelectorAll(".branch-role input[type=\"checkbox\"].allowAnonymous");


Better typing

Same thing with how its not possible.

petschekr · 2018-03-09T18:10:47Z

client/js/admin.ts

+
+			// This operation is all or nothing because it will only error if a branch was just made into an Application branch
+			try {
+				branchData.allowAnonymous = (branchRoles[i].querySelector("fieldset.applicationBranchOptions input[type=\"checkbox\"].allowAnonymous") as HTMLInputElement).checked;


Can you make fieldset.applicationBranchOptions input[type="checkbox"] a variable or something somewhere? Seems like it's getting repeated a lot. Or consider running a querySelector() on that element up front and querySelector() on the returned element for better performance and readability

petschekr · 2018-03-09T18:11:19Z

client/js/application.ts

@@ -2,7 +2,10 @@ enum FormType {
 	Application,
 	Confirmation
 }
-let formType = window.location.pathname.match(/^\/apply/) ? FormType.Application : FormType.Confirmation;


Whyyyyyyyyy globals. There has to be a better way

I removed this crime. I literally removed this global.

petschekr · 2018-03-09T18:11:55Z

client/js/application.ts

-		window.location.assign("/");
+
+		if (unauthenticated) {
+			(document.querySelector("form") as HTMLFormElement).reset();


Cast not needed here. Typescript can tell that searching for "form" will always return a form element

The issue is that the type returned is HTMLFormElement | null and I want to force it to be not null.

petschekr · 2018-03-09T18:17:27Z

server/routes/api/user.ts

+			next();
+		}
+		else {
+			response.status(408).json({


Is a request timeout the appropriate status code for this?

you are a sassyboi

literally you did this

petschekr · 2018-03-09T18:23:56Z

Still need to test and run it on my machine but overall looks good

Anonymous/walk-in registration I'm sure I won't regret this

bunsenmcdubbs requested review from petschekr and kexin-zhang March 5, 2018 21:10

bunsenmcdubbs added enhancement Adds or suggests a new feature, rewrite, or other enhancement to the codebase high priority labels Mar 5, 2018

bunsenmcdubbs mentioned this pull request Mar 5, 2018

Allow anonymous form submissions #194

Closed

petschekr added this to the BuildGT 2018 milestone Mar 5, 2018

bunsenmcdubbs changed the title ~~[WIP] Anonymous form submission~~ Anonymous registration Mar 7, 2018

bunsenmcdubbs added 13 commits March 7, 2018 01:55

Remove request url matching and use types instead

c3df883

Implement auto-accept for after application submitted

d68a23f

Implement no-confirmation workflow after applicant is accepted

1667838

Start refactor of branch (apply/confirm) redirect middleware

f9b0461

Hide and display proper options for users depending on new branch opt…

ed73b2c

…ions

Clear user accepted and attending values when deleting application

720cc2d

Add auto-accept and skip-confirmation options in admin panel

1fdbd60

Add "allow anonymous" option to admin panel (and db)

5bdd02f

Refactor branch redirection middleware

d134f70

Use addEventListener when setting click handlers

b676ed5

Implement anonymous registration

92107a0

Display registration link in admin panel for public branches

d13d6db

Clarify location of config file

3963457

bunsenmcdubbs force-pushed the anonymous-form-submission branch from b38b8e8 to 3963457 Compare March 7, 2018 06:55

bunsenmcdubbs requested a review from illegalprime March 7, 2018 07:04

bunsenmcdubbs changed the title ~~Anonymous registration~~ Anonymous/walk-in registration Mar 7, 2018

bunsenmcdubbs added 3 commits March 8, 2018 18:37

Encode URLs in admin screen

6462123

Protect walkin/anonymous registration by enforcing admin user

a0669b1

Uncheck allow-anonymous open when skip confirmation is disabled

737bd47

Fix typos

224668c

bunsenmcdubbs requested a review from mjkaufer March 9, 2018 03:26

Prevent anonymous registration with existing email

04dc661

petschekr requested changes Mar 9, 2018

View reviewed changes

Small fixes from PR feedback

2ae1708

bunsenmcdubbs force-pushed the anonymous-form-submission branch from 24fbde1 to 2ae1708 Compare March 10, 2018 02:56

petschekr added 2 commits March 9, 2018 23:17

Small type cast fix

9fdce67

Bump version to 1.13.0

06699a2

petschekr approved these changes Mar 10, 2018

View reviewed changes

petschekr merged commit 8cf4601 into master Mar 10, 2018

ehsanmasdar mentioned this pull request Apr 18, 2018

Confirmation throws errors after #205 #211

Closed

petschekr deleted the anonymous-form-submission branch February 25, 2019 18:44

rahulrajus pushed a commit that referenced this pull request Jul 22, 2021

Merge pull request #205 from HackGT/anonymous-form-submission

f1ad2b4

Anonymous/walk-in registration I'm sure I won't regret this

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Anonymous/walk-in registration #205

Anonymous/walk-in registration #205

bunsenmcdubbs commented Mar 5, 2018 •

edited

hackgbot commented Mar 5, 2018

bunsenmcdubbs commented Mar 7, 2018 •

edited

bunsenmcdubbs commented Mar 7, 2018

bunsenmcdubbs commented Mar 7, 2018 •

edited

petschekr Mar 9, 2018

bunsenmcdubbs Mar 9, 2018

petschekr Mar 9, 2018

petschekr Mar 9, 2018

bunsenmcdubbs Mar 9, 2018

petschekr Mar 9, 2018

bunsenmcdubbs Mar 9, 2018

petschekr Mar 9, 2018

bunsenmcdubbs Mar 9, 2018

petschekr Mar 9, 2018

bunsenmcdubbs Mar 9, 2018

petschekr Mar 9, 2018

petschekr Mar 9, 2018

bunsenmcdubbs Mar 9, 2018 •

edited

petschekr Mar 9, 2018

bunsenmcdubbs Mar 9, 2018

petschekr Mar 9, 2018

bunsenmcdubbs Mar 9, 2018

bunsenmcdubbs Mar 9, 2018

petschekr commented Mar 9, 2018

Anonymous/walk-in registration #205

Anonymous/walk-in registration #205

Conversation

bunsenmcdubbs commented Mar 5, 2018 • edited

hackgbot commented Mar 5, 2018

bunsenmcdubbs commented Mar 7, 2018 • edited

bunsenmcdubbs commented Mar 7, 2018

bunsenmcdubbs commented Mar 7, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bunsenmcdubbs Mar 9, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

petschekr commented Mar 9, 2018

bunsenmcdubbs commented Mar 5, 2018 •

edited

bunsenmcdubbs commented Mar 7, 2018 •

edited

bunsenmcdubbs commented Mar 7, 2018 •

edited

bunsenmcdubbs Mar 9, 2018 •

edited