Add configurable word and character limits to questions #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…igned during config load
petschekr
added
enhancement
evan10s
reviewed
Jul 8, 2019
client/js/application.ts
Outdated
| let wordCountInputs = document.querySelectorAll("[data-max-word-count], [data-min-word-count]") as NodeListOf<HTMLInputElement | HTMLTextAreaElement>; | ||
| for (let i = 0; i < wordCountInputs.length; i++) { | ||
| wordCountInputs[i].addEventListener("input", e => { | ||
| let target = e.target as HTMLInputElement | HTMLTextAreaElement; |
There was a problem hiding this comment.
Good call. I'm too used to Rust at the moment where everything is immutable by default and it also uses let
| {{#ifCond this.type "textarea"}} | ||
| <textarea name="{{this.name}}" id="form-{{this.name}}" placeholder="{{this.placeholder}}" {{required this.required}}>{{this.value}}</textarea> | ||
| <textarea name="{{this.name}}" id="form-{{this.name}}" placeholder="{{this.placeholder}}" {{required this.required}} minlength="{{this.minCharacterCount}}" maxlength="{{this.maxCharacterCount}}" data-max-word-count="{{this.maxWordCount}}" data-min-word-count="{{this.minWordCount}}">{{this.value}}</textarea> |
There was a problem hiding this comment.
Does this still add the minlength and other attributes even if those aren't defined in the JSON file?
There was a problem hiding this comment.
Yeah it does
Is it worth adding a Handlebars partial to only add the attribute if it is set?
| @@ -45,7 +60,7 @@ | |||
| <input type="file" name="{{this.name}}" id="form-{{this.name}}" placeholder="{{this.placeholder}}" {{required this.required}} /> | |||
| {{/if}} | |||
| {{else}} | |||
| <input type="{{this.type}}" name="{{this.name}}" id="form-{{this.name}}" placeholder="{{this.placeholder}}" {{required this.required}} value="{{this.value}}" /> | |||
| <input type="{{this.type}}" name="{{this.name}}" id="form-{{this.name}}" placeholder="{{this.placeholder}}" {{required this.required}} minlength="{{this.minCharacterCount}}" maxlength="{{this.maxCharacterCount}}" data-max-word-count="{{this.maxWordCount}}" data-min-word-count="{{this.minWordCount}}" value="{{this.value}}" /> | |||
ehsanmasdar
requested changes
Jul 8, 2019
ehsanmasdar
approved these changes
Jul 8, 2019
ehsanmasdar
approved these changes
Jul 8, 2019
rahulrajus
pushed a commit
that referenced
this pull request
Jul 22, 2021
Add configurable word and character limits to questions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maxWordCount,minWordCount,maxCharacterCount, andminCharacterCountto fields that accept textCloses #268