asdfsadf

HackIllinois · Jan 25, 2024 · c06071c · c06071c
1 parent 8d77237
commit c06071c
Showing 1 changed file with 0 additions and 9 deletions.
diff --git a/src/services/mentor/mentor-router.ts b/src/services/mentor/mentor-router.ts
@@ -50,7 +50,6 @@ const mentorRouter: Router = Router();
  *     {"error": "InvalidPermission"}
  */
 mentorRouter.post("/", strongJwtVerification, async (req: Request, res: Response, next: NextFunction) => {
-    const mentorName: string | undefined = req.body.mentorName;
     const mentorName: string | undefined = req.body.mentorName;
     const payload: JwtPayload = res.locals.payload as JwtPayload;
 
@@ -64,7 +63,6 @@ mentorRouter.post("/", strongJwtVerification, async (req: Request, res: Response
     //generate mentorId, add document to database, return generated document in response
     const mentorId: string = crypto.randomBytes(Config.MENTOR_BYTES_GEN).toString("hex");
 
-    const officeHours: OfficeHoursFormat = { mentorId: mentorId, mentorName: mentorName, attendees: [] };
     const officeHours: OfficeHoursFormat = { mentorId: mentorId, mentorName: mentorName, attendees: [] };
 
     const newOfficeHours = await Models.MentorOfficeHours.create(officeHours);
@@ -117,13 +115,11 @@ mentorRouter.get("/", strongJwtVerification, async (_: Request, res: Response, n
 
     const officeHours: OfficeHoursFormat[] | null = await Models.MentorOfficeHours.find();
 
-    if (!officeHours) {
     if (!officeHours) {
         return next(new RouterError(StatusCode.ServerErrorInternal, "InternalError"));
     }
 
     return res.status(StatusCode.SuccessOK).send(officeHours);
-    return res.status(StatusCode.SuccessOK).send(officeHours);
 });
 
 /**
@@ -156,7 +152,6 @@ mentorRouter.get("/", strongJwtVerification, async (_: Request, res: Response, n
  *     {"error": "InvalidPermission"}
  */
 mentorRouter.delete("/", strongJwtVerification, async (req: Request, res: Response, next: NextFunction) => {
-    const mentorId: string | undefined = req.body.mentorId;
     const mentorId: string | undefined = req.body.mentorId;
     const payload: JwtPayload = res.locals.payload as JwtPayload;
 
@@ -170,7 +165,6 @@ mentorRouter.delete("/", strongJwtVerification, async (req: Request, res: Respon
 
     const officeHours: OfficeHoursFormat | null = await Models.MentorOfficeHours.findOne({ mentorId: mentorId });
 
-    if (!officeHours) {
     if (!officeHours) {
         return next(new RouterError(StatusCode.ClientErrorBadRequest, "MentorNotFound"));
     }
@@ -224,7 +218,6 @@ mentorRouter.delete("/", strongJwtVerification, async (req: Request, res: Respon
  *     {"error": "AlreadyCheckedIn"}
  */
 mentorRouter.post("/attendance/", strongJwtVerification, async (req: Request, res: Response, next: NextFunction) => {
-    const mentorId: string | undefined = req.body.mentorId;
     const mentorId: string | undefined = req.body.mentorId;
     const payload: JwtPayload = res.locals.payload as JwtPayload;
 
@@ -238,13 +231,11 @@ mentorRouter.post("/attendance/", strongJwtVerification, async (req: Request, re
 
     const officeHours: OfficeHoursFormat | null = await Models.MentorOfficeHours.findOne({ mentorId: mentorId });
 
-    if (!officeHours) {
     if (!officeHours) {
         return next(new RouterError(StatusCode.ClientErrorBadRequest, "MentorNotFound"));
     }
 
     // Checks whether the attendee has already checked in for the office hours
-    if (officeHours.attendees.includes(payload.id)) {
     if (officeHours.attendees.includes(payload.id)) {
         return next(new RouterError(StatusCode.ClientErrorBadRequest, "AlreadyCheckedIn"));
     }