-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add auth tests #126
Merged
Merged
Add auth tests #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most stupidest endpoint to ever exist, this is why we write tests instead!
Adds tests & adds authorization check to listing all users under role
Allows getRoles to return undefined when roles cannot be found. This should probably be restructured nicer at some point.
Also add tests to verify works in future. Refresh was causing provider to be appended again (google123 -> googlegoogle123) for new token
AydanPirani
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, feel free to merge!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests for every auth endpoint, and fixes a lot of stuff (blame: @AydanPirani, test your stuff!)
Resolves #108
GET /auth/test/was only used for testingGET /auth/list/roles/no current use, no practical useCoverage:
Most of what is not covered is error handling, which is really hard to mock. My upcoming error handling pr fix should solve this.
I am taking a break from jest testing after this.